Skip to content

Python SDK: Allow specifying status code and headers with quark responses #917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 4, 2025
Merged

Python SDK: Allow specifying status code and headers with quark responses #917

merged 1 commit into from
Jun 4, 2025

Conversation

@gazpachoking
Copy link
Contributor

@gazpachoking gazpachoking commented Jun 3, 2025 •
edited
Loading

  • Allows specifying headers and status code with a quart datastar response
  • Adds typing for quart's make_datastar_response refs Add type hints to the Python SDK #768
  • Doesn't disable the default quart response timeout unless a generator is returned (only disables if we are streaming a response)

@gazpachoking
Allow passing response code and headers to make_datastar_response, li…
ca5d0b7 
…ke native make_response

Fix typing for quart make_datastar_response
@bencroker bencroker merged commit 686f603 into starfederation:develop Jun 4, 2025
1 check passed
@bencroker
Copy link
Collaborator

bencroker commented Jun 4, 2025

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bencroker bencroker bencroker approved these changes

@delaneyj delaneyj Awaiting requested review from delaneyj delaneyj is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gazpachoking @bencroker