Skip to content

Conversation

@gazpachoking
Copy link
Contributor

Add some more examples to clarify PatchElements events in the ADR. Particularly showing the remove mode with and without elements specified.

@bencroker
Copy link
Collaborator

Thanks for the PR! I’m not fond of the use of : for comments, as it could cause confusion. Can you please split the details element into one per example, named accordingly?

Split example block and move with other examples
@gazpachoking
Copy link
Contributor Author

Okay, split out all the new examples, and put them up with the existing examples. Also explicitly documented the elements argument now.

@bencroker bencroker merged commit 0de41ea into starfederation:release-candidate Jun 19, 2025
1 check failed
@bencroker
Copy link
Collaborator

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants