Skip to content

Conversation

@JeremS
Copy link
Contributor

@JeremS JeremS commented Jun 23, 2025

This PR mainly contains the changes for the new ADR:

  • the public API functions have been renamed
  • the remove-elements and the execute-script functionality is now sugar on top of patch-elements
  • the hello world example and all the code snippets for the website are updated to the new names
  • the SDK examples have also been updated to the new API

I used these changes as an opportunity to review some things:

  • I moved the clj-kondo config to allows other lib to use the starfederation.datastar.clojure ns for their clj-kondo configs.
  • I refactored the unit tests for the core API, they now should be easier to understand maintain and are more repl friendly

This is a draft PR at the moment, the smoke test could use the same treatment as the core unit tests. Also I haven't run them against a D* RC that uses the new ADR...

@JeremS JeremS changed the title Convertion to new ADR and some improvements clojure SDK - Convertion to new ADR and some improvements Jun 25, 2025
@JeremS JeremS closed this Jun 30, 2025
@JeremS JeremS force-pushed the release-candidate branch from e971887 to cd59cf8 Compare June 30, 2025 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant