Skip to content

Conversation

@ismasan
Copy link
Contributor

@ismasan ismasan commented Jul 1, 2025

In this PR:

  • Update Ruby constants template, regenerate constants and fix code.
  • Fix #execute_script to use data-effect="el.remove()" instead of onload="this.remove()"
  • Document build task so that I don't forget about it next time.

@bencroker
Copy link
Collaborator

Looking good! One thing to change is that the attribute default should be empty.

@ismasan
Copy link
Contributor Author

ismasan commented Jul 2, 2025

@bencroker I've removed that attribute default check since it's not needed anymore.

@bencroker bencroker merged commit 1d325da into starfederation:release-candidate Jul 2, 2025
1 check failed
@bencroker
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants