Skip to content

Ruby fix event end and pass bash tests #978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 9, 2025
Merged

Ruby fix event end and pass bash tests #978

merged 3 commits into from
Jul 9, 2025

Conversation

@ismasan
Copy link
Contributor

@ismasan ismasan commented Jul 9, 2025

  • Fix SSE event termination (single \n instead of double)
  • Fix test app and make all (available) bash tests pass
  • Fix top-level Ruby example to use release-candidate JS bundle

@bencroker bencroker merged commit 4dabb24 into starfederation:release-candidate Jul 9, 2025
1 check failed
@bencroker
Copy link
Collaborator

bencroker commented Jul 9, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@delaneyj delaneyj Awaiting requested review from delaneyj

@bencroker bencroker Awaiting requested review from bencroker

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ismasan @bencroker