Simplify race/one implementations #603
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Semantically, these two functions behave the same though race offers an additional overload for heterogenous futures (and had a less expressive return type - fixed here). * fix `race` leak where callback would not be removed from unfinished futures * reduce memory allocations for varargs version * return full future type in `race` when possible In the future, we may want to deprecate either `one` or `race` since they are redundant at this point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Semantically, these two functions behave the same though race offers an additional overload for heterogenous futures (and had a less expressive return type - fixed here).
racewhen possibleIn the future, we may want to deprecate either
oneorracesince they are redundant at this point.