Flavor automatic serialization #122
Conversation
| type Flavor = JsonReader.Flavor | ||
|
|
||
| when value is JsonString: | ||
| autoSerializeCheck(Flavor, JsonString) |
There was a problem hiding this comment.
this looks a bit messy - ie first we create a handler for the type, then we disable it "maybe" - it sounds expensive, compile-time wise and a bit messy to follow - ditto the use of the macro cache feels .. expensive ..
can we think of a different way to structure this code? could we make it work by specializing for Json[DefaultFlavor] and then somehow "forwarding" calls to that if the user wants to borrow that serialization, also to avoid bloat?
There was a problem hiding this comment.
this looks a bit messy
Yes, a bit messy. But that is the cost of a simple interface to disable default serializer at various granularity. Both concrete type and type classes can use the same interface. Otherwise, the messiness and complexity will be more harder to follow.
could we make it work by specializing ... to avoid bloat?
Yes, but that will come in separate PR, it's a different topic, and quite thorough refactoring.
2 participants
fix #121