Replace INTERVALS_PER_SLOT with BPS based slot timings
#7694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables configuration of: - `PROPOSER_REORG_CUTOFF_BPS` (only used for REST API and constraints) - `ATTESTATION_DUE_BPS` (must be ≥ reorg cutoff) - `AGGREGATE_DUE_BPS` (must be ≥ att cutoff and ≤ 10k) - `SYNC_MESSAGE_DUE_BPS` (must be == att cutoff) - `CONTRIBUTION_DUE_BPS` (must be == agg cutoff) When `INTERVALS_PER_SLOT` was retired, they changed it to be slightly off, 1/3 became 3333/10000 and 2/3 became 6667/10000, so there is a tiny bit more time to send attestations, and a tiny bit less for aggregates. Also updated VC deadlines to be based on the dynamic config. The constraints are just what Nimbus assumes. The spec does not define valid ranges of config values.
Contributor
Author
Contributor
Both of these have been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables configuration of:
PROPOSER_REORG_CUTOFF_BPS(only used for REST API and constraints)ATTESTATION_DUE_BPS(must be ≥ reorg cutoff)AGGREGATE_DUE_BPS(must be ≥ att cutoff and ≤ 10k)SYNC_MESSAGE_DUE_BPS(must be == att cutoff)CONTRIBUTION_DUE_BPS(must be == agg cutoff)When
INTERVALS_PER_SLOTwas retired, they changed it to be slightly off, 1/3 became 3333/10000 and 2/3 became 6667/10000, so there is a tiny bit more time to send attestations, and a tiny bit less for aggregates.Also updated VC deadlines to be based on the dynamic config.
The constraints are just what Nimbus assumes. The spec does not define valid ranges of config values.