-
Notifications
You must be signed in to change notification settings - Fork 296
Clean up genesis init helpers #7713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* create testnet/test genesis starting from phase0 and upgrade to the correct fork, like the spec suggests * reduce mem usage and number of copies while upgrading * add gloas to `ncli_testnet` generator * speed up mock deposit processing by skipping bls ops for most state creations and caching them for the others (attestation pool tests go from minutes to seconds) * consolidate the various ways to create deposits and states in the test suite to a single flow * make sure deposit creation uses the correct fork version in tests
etan-status
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's something about current/next fork fields that's different when doing sequential upgrade instead of a usual genesis (where both fields are the same)
hm, yeah, we had these checks that I don't know where they came from that the genesis fork has the same versions in current/prev version .. I think that's our own invention and not a spec requirement per se so it was removed in #7705 - hopefully I nabbed all of them.. |
|
Maybe an option to check genesis states from hoodi etc which started post phase0 |
|
https://github.com/eth-clients/hoodi/blob/main/parsed/parsedConsensusGenesis.json: |
|
|
||
| doAssert forkyState.data.validators.len > 0 | ||
|
|
||
| # let outGenesisExt = splitFile(outGenesis).ext |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the commented-out code intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, it's in the current code too.
ncli_testnetgenerator