Skip to content

cleanup event listeners for keyboard #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brainydexter wants to merge 1 commit into
base: master
Choose a base branch
from
Open

cleanup event listeners for keyboard #34

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion Three.js/js/KeyboardState.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@
* keyboard.down("A") -- true for one update cycle after key is pressed
* keyboard.pressed("A") -- true as long as key is being pressed
* keyboard.up("A") -- true for one update cycle after key is released
* (4) cleanup keyboard event listeners when you no longer need them
* keyboard.destroy();
*
* See KeyboardState.k object data below for names of keys whose state can be polled
*/
Expand All @@ -22,6 +24,14 @@ KeyboardState = function()
document.addEventListener("keyup", KeyboardState.onKeyUp, false);
}

// cleanup - stop listening to key events
KeyboardState.prototype.destroy = function()
{
// unbind keyEvents
document.removeEventListener("keydown", KeyboardState.onKeyDown, false);
document.removeEventListener("keyup", KeyboardState.onKeyUp, false);
}

///////////////////////////////////////////////////////////////////////////////

KeyboardState.k =
Expand Down Expand Up @@ -109,4 +119,4 @@ KeyboardState.prototype.debug = function()
console.log(list);
}

///////////////////////////////////////////////////////////////////////////////
///////////////////////////////////////////////////////////////////////////////