Remove restore-keys from caching #349
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexdempster44
approved these changes
Feb 20, 2025
mbastos-sis
approved these changes
Feb 20, 2025
lbonsey1
changed the title
lbonsey1
changed the title
|
@bartekpacia could you have a look at this please? It would be nice to get it merged in. |
sophie-maney
added a commit
to FurryApp/flutter-action
that referenced
this pull request
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in open issue #319, the
restore-keysspecified withinaction.yamlleads to some unpredictable behaviour; apub getcache-miss could result in a different hashed lock cache to be returned instead. In our experience, this has caused pipelines to fail, as the codebase is relying on packages which are not present in the pub cache. As @rolandmosimann recommends, I feel this behaviour should be removed, to fix this problem.As a result, this PR removes the misleading
restore-keyonpub getcaching, as well as the unnecessary declaration of arestore-keymatching exactly thekey. Let me know if you've got any questions 😄