Support dynamic values for PUB-CACHE-PATH #363
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the caching section of the README, both
CACHE-PATHandPUB-CACHE-PATHare supposed to support dynamic values, like:version:and:arch:.I wanted to implement caching for my usage of
subosito/flutter-action@v2, so I tried adding the block from the README:In my action output, I saw that
PUB_CACHE_PATHstill contained the placeholders:This PR applies the
expand_keyfunction on PUB_CACHE, updates the README to fix a missing dash in the example path (to match the default[ -z "$PUB_CACHE_KEY" ] && PUB_CACHE_KEY="flutter-pub-:os:-:channel:-:version:-:arch:-:hash:"), and adds tests for PUB_CACHE_KEY and PUB_CACHE_PATH.Before this change:
After this change: