Skip to content

Conversation

@rugwirobaker
Copy link
Contributor

No description provided.

Comment on lines 193 to 195
for k, v := range metadata {
params += fmt.Sprintf("metadata.%s=%s", k, v)
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't separating out URL parameters with a &. A better approach would be to just use url.Values so it can handle encoding too. Also,it doesn't look like state is even used by any of the callers of List() so you could just remove it.

q := make(url.Values)
for k, v := range metadata {
	q.Set("metadata." + k, v)
}

var getEndpoint = ""
if len(q) > 0 {
	getEndpoint = "?" + q.Encode()
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants