Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/bumpy-radios-live.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

type `currentTarget` in `on` function
5 changes: 4 additions & 1 deletion packages/svelte/src/events/public.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,10 @@ export function on<Type extends keyof DocumentEventMap>(
export function on<Element extends HTMLElement, Type extends keyof HTMLElementEventMap>(
element: Element,
type: Type,
handler: (this: Element, event: HTMLElementEventMap[Type]) => any,
handler: (
this: Element,
event: HTMLElementEventMap[Type] & { currentTarget: EventTarget & Element }
) => any,
options?: AddEventListenerOptions | undefined
): () => void;
/**
Expand Down
2 changes: 2 additions & 0 deletions packages/svelte/tests/types/events.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ on(window, 'click', (e) => e.button);

on(document, 'click', (e) => e.button);

on(document.createElement('input'), 'input', (e) => e.currentTarget?.value);

on(
document.body,
'clidck',
Expand Down
5 changes: 4 additions & 1 deletion packages/svelte/types/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2823,7 +2823,10 @@ declare module 'svelte/events' {
export function on<Element extends HTMLElement, Type extends keyof HTMLElementEventMap>(
element: Element,
type: Type,
handler: (this: Element, event: HTMLElementEventMap[Type]) => any,
handler: (
this: Element,
event: HTMLElementEventMap[Type] & { currentTarget: EventTarget & Element }
) => any,
options?: AddEventListenerOptions | undefined
): () => void;
/**
Expand Down
Loading