fix: add explicit-object-schema flag (#2113) #2202
Merged
+94
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-kmiecik
force-pushed
the
issue2113-explicit-object-schema
branch
from
14266aa to
073c7d7
Compare
daniel-kmiecik
force-pushed
the
issue2113-explicit-object-schema
branch
from
073c7d7 to
d180681
Compare
frantuma
suggested changes
Jun 16, 2025
|
|
||
| private boolean aggregateCombinators; | ||
|
|
||
| private ParseOptions parseOptions; |
Contributor
There was a problem hiding this comment.
I would initialize this to new ParseOptions() to avoid NPEs if folks keep using other constructors
daniel-kmiecik
force-pushed
the
issue2113-explicit-object-schema
branch
from
76d0b1a to
ea8f519
Compare
frantuma
approved these changes
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.