🍒 [lldb] improve the heuristics for checking if a terminal supports Unicode #12014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@swift-ci please test |
1 similar comment
Author
|
@swift-ci please test |
charles-zablit
force-pushed
the
charles-zablit/lldb/better-unicode-check-to-swift-release-6.3
branch
from
20a971c to
754bc09
Compare
Author
|
@swift-ci please test |
NFC patch which moves `DiagnosticsRendering` from `Utility` to `Host`. This refactoring is needed for llvm#168603. It adds a method to check whether the current terminal supports Unicode or not. This will be OS dependent and a better fit for `Host`. Since `Utility` cannot depend on `Host`, `DiagnosticsRendering` must live in `Host` instead. (cherry picked from commit 0c7d826)
…code (llvm#171832) This patch improves the way lldb checks if the terminal it's opened in (if any) supports Unicode or not. On POSIX systems, we check if `LANG` contains `UTF-8`. On Windows, we always return `true` since we use the `WriteToConsoleW` api. This is a relanding of llvm#168603. The tests failed because the bots support Unicode but the tests expect ASCII. To avoid different outputs depending on the environment the tests are running in, this patch always force ASCII in the tests. (cherry picked from commit 7345233)
…72038) This patch fixes a test failure introduced by llvm#171832 due to a check which was not properly updated. (cherry picked from commit 8515dda)
charles-zablit
force-pushed
the
charles-zablit/lldb/better-unicode-check-to-swift-release-6.3
branch
from
754bc09 to
a732608
Compare
Author
|
@swift-ci please test |
Author
|
@swift-ci please test macos |
adrian-prantl
approved these changes
Dec 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.