[NFC][BoundsSafety] Unbreak BoundsSafety/Sema/check-format-arguments.c
#12021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test was broken by llvm#166738 ``` commit 1df7b51 Author: Vladimir Vuksanovic <[email protected]> Date: Fri Dec 5 15:04:12 2025 +0100 [Sema] Suggest missing format attributes (llvm#166738) ``` It seems a different warning (`-Wmissing-format-attribute`) is emitted for the case where a non-format string argument is passed to `foo`. This new behavior seems a little confusing * There's no longer a warning about the call to `foo` not taking a string literal. * The suggested attribute conflicts with the `format` attribute that's already on bar. Dealing with this odd behavior is out-of-scope though for fixing this test case though. rdar://166071403
delcypher
requested review from
apple-fcloutier,
hnrklssn,
patrykstefanski and
rapidsna
delcypher
added
the
clang:bounds-safety
Author
|
Landing now to fix this in CI. |
Author
|
@apple-fcloutier You may want to look at this because I think you reviewed the upstream patch to this diagnostic. The new behavior for this example doesn't make a huge amount of sense to me but maybe I'm missing something. |
|
I was doing it here for stable/21.x but CI isn't cooperating. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test was broken by llvm#166738
It seems a different warning (
-Wmissing-format-attribute) is emitted for the case where a non-format string argument is passed tofoo. This new behavior seems a little confusingfoonot taking a string literal.formatattribute that's already on bar.Dealing with this odd behavior is out-of-scope though for fixing this test case though.
rdar://166071403