-
Notifications
You must be signed in to change notification settings - Fork 1.4k
GHA: Enable testing #9450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bkhouri
wants to merge
3
commits into
swiftlang:main
Choose a base branch
from
bkhouri:t/main/gh9427_rdar165491718_enable_testing_in_gha
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+23
−11
Open
GHA: Enable testing #9450
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,11 +12,12 @@ concurrency: | |
| cancel-in-progress: true | ||
|
|
||
| jobs: | ||
| tests-using-native: | ||
| tests: | ||
| needs: [soundness] | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| executableTargetBuildSystem: ["native"] | ||
| buildSystem: ["native", "swiftbuild"] | ||
| linuxSwiftVersion: ['["nightly-main", "nightly-6.2"]', '["nightly-main"]'] | ||
| enable_windows_checks: [true] | ||
|
|
@@ -27,39 +28,46 @@ jobs: | |
| enable_windows_checks: true | ||
| - buildSystem: "native" | ||
| linuxSwiftVersion: '["nightly-main"]' | ||
| name: Test (${{ matrix.buildSystem }}) | ||
| name: Test (${{ matrix.buildSystem }}) (exectable target built using ${{ matrix.executableTargetBuildSystem }}) | ||
| uses: swiftlang/github-workflows/.github/workflows/[email protected] | ||
| with: | ||
| linux_os_versions: '["amazonlinux2", "bookworm", "noble", "jammy", "rhel-ubi9"]' | ||
| linux_swift_versions: ${{ matrix.linuxSwiftVersion }} | ||
| linux_pre_build_command: ./.github/scripts/prebuild.sh | ||
| linux_build_command: 'swift run swift-build --build-tests --build-system ${{ matrix.buildSystem}}' | ||
| linux_build_command: 'swift run --build-system ${{ matrix.executableTargetBuildSystem }} swift-build --build-tests && swift run --build-system ${{ matrix.executableTargetBuildSystem }} swift-test --parallel --build-system ${{ matrix.buildSystem}}' | ||
| windows_swift_versions: '["nightly-main"]' | ||
| windows_pre_build_command: 'Invoke-Program .\.github\scripts\prebuild.ps1' | ||
| windows_build_command: 'Invoke-Program swift run swift-build --build-tests --build-system ${{ matrix.buildSystem}}' | ||
| windows_build_command: 'Invoke-Program swift run --build-system ${{ matrix.executableTargetBuildSystem }} swift-build --build-tests && swift run --build-system ${{ matrix.executableTargetBuildSystem }} -Xlinker /ignore:4217 swift-test -Xlinker /ignore:4217 --parallel --build-system ${{ matrix.buildSystem}}' | ||
| enable_windows_checks: ${{ matrix.enable_windows_checks }} | ||
| enable_ios_checks: true | ||
| enable_macos_checks: true | ||
| macos_exclude_xcode_versions: "[{\"xcode_version\": \"16.3\"}, {\"xcode_version\": \"16.4\"}]" | ||
| macos_build_command: 'swift run swift-build --build-tests --build-system ${{ matrix.buildSystem}}' | ||
| macos_build_command: 'swift run --build-system ${{ matrix.executableTargetBuildSystem }} swift-build --build-tests && swift run --build-system ${{ matrix.executableTargetBuildSystem }} swift-test --parallel --build-system ${{ matrix.buildSystem}}' | ||
| ios_build_command: 'swift run --build-system ${{ matrix.executableTargetBuildSystem }} swift-build --build-tests && swift run --build-system ${{ matrix.executableTargetBuildSystem }} swift-test --parallel --build-system ${{ matrix.buildSystem }} --sdk \"$(xcrun --sdk iphoneos --show-sdk-path)\" --triple arm64-apple-ios' | ||
|
|
||
| tests-using-swiftbuild: | ||
| name: Test (all SwiftBuild) | ||
| build-using-swiftbuild: | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| executableTargetBuildSystem: ["swiftbuild"] | ||
| buildSystem: ["swiftbuild"] | ||
| name: Build (${{ matrix.buildSystem }}) (exectable target built using ${{ matrix.executableTargetBuildSystem }}) | ||
| needs: [soundness] | ||
| uses: swiftlang/github-workflows/.github/workflows/[email protected] | ||
| with: | ||
| linux_os_versions: '["amazonlinux2", "bookworm", "noble", "jammy", "rhel-ubi9"]' | ||
| linux_swift_versions: '["nightly-main"]' | ||
| linux_pre_build_command: ./.github/scripts/prebuild.sh | ||
| linux_build_command: 'swift run --build-system swiftbuild swift-build --build-tests --build-system swiftbuild' | ||
| linux_build_command: 'swift run --build-system ${{ matrix.executableTargetBuildSystem }} swift-build --build-tests --build-system ${{ matrix.buildSystem }}' | ||
| enable_windows_checks: false | ||
| windows_swift_versions: '["nightly-main"]' | ||
| windows_pre_build_command: 'Invoke-Program .\.github\scripts\prebuild.ps1' | ||
| windows_build_command: 'Invoke-Program swift run --build-system swiftbuild swift-build --build-tests --build-system swiftbuild' | ||
| windows_build_command: 'Invoke-Program swift run --build-system ${{ matrix.executableTargetBuildSystem }} swift-build --build-tests --build-system ${{ matrix.buildSystem }}' | ||
| enable_ios_checks: true | ||
| enable_macos_checks: true | ||
| macos_exclude_xcode_versions: "[{\"xcode_version\": \"16.3\"}, {\"xcode_version\": \"16.4\"}]" | ||
| macos_build_command: 'swift run --build-system swiftbuild swift-build --build-tests --build-system swiftbuild' | ||
| macos_build_command: 'swift run --build-system ${{ matrix.executableTargetBuildSystem }} swift-build --build-tests --build-system ${{ matrix.buildSystem }}' | ||
| ios_build_command: 'swift run --build-system ${{ matrix.executableTargetBuildSystem }} swift-build --build-tests --build-system ${{ matrix.buildSystem }} --sdk \"$(xcrun --sdk iphoneos --show-sdk-path)\" --triple arm64-apple-ios' | ||
|
|
||
| soundness: | ||
| name: Soundness | ||
|
|
@@ -71,3 +79,7 @@ jobs: | |
| api_breakage_check_enabled: false | ||
| format_check_enabled: false | ||
| shell_check_enabled: false | ||
| docs_check_enabled: true | ||
| broken_symlink_check_enabled: true | ||
| python_lint_check_enabled: true | ||
| yamllint_check_enabled: true | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: why turn off very verbose here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find it significantly increases the log, making it difficult for view the console logs in Jenkins - not sure how GitHub Actions handles the larges logs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, it's my understanding it was added by @daveinglis to help troubleshoot CI build failure in a PR.