Diagnosing a private setter being accessed from the inlinable function. #86076
+54
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci please smoke test |
slavapestov
requested changes
Dec 16, 2025
lib/Sema/ResilienceDiagnostics.cpp
Outdated
| if (accessor->getAccessorKind() == AccessorKind::Set && | ||
| accessor->getFormalAccess() == AccessLevel::Private) { | ||
| auto *storage = accessor->getStorage(); | ||
| if (storage->getAttrs().hasAttribute<UsableFromInlineAttr>()) { |
Contributor
There was a problem hiding this comment.
What if the storage is public? We don't want to check for this attribute directly, instead check it using access scopes like we do for everything else.
sepy97
force-pushed
the
inlinable-function-private-setter
branch
2 times, most recently
from
1dca620 to
6a13458
Compare
Contributor
Author
|
@swift-ci please smoke test |
sepy97
force-pushed
the
inlinable-function-private-setter
branch
from
6a13458 to
4ec9a06
Compare
Contributor
Author
|
@swift-ci please smoke test |
sepy97
force-pushed
the
inlinable-function-private-setter
branch
from
4ec9a06 to
4af1a8b
Compare
sepy97
force-pushed
the
inlinable-function-private-setter
branch
from
4af1a8b to
38cbc7d
Compare
Contributor
Author
|
@swift-ci please smoke test |
1 similar comment
Contributor
Author
|
@swift-ci please smoke test |
Contributor
Author
|
@swift-ci please smoke test linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swift compiler allowed accessing a private setter from an @inlinable function. This change detects and diagnose it with a corresponding error.
rdar://81879146