[Overlays] Set use-external-names to true in overlay file
#86092
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`use-external-names` needs to be true in the overlay file, otherwise the incremental build will not work. If the value is false, the dependency scanner is reporting virtual path as dependency, thus build system cannot correctly validate if the dependencies are up-to-date since it does not know the on disk representation.
cachemeifyoucan
requested review from
compnerd,
edymtt,
etcwilde and
justice-adams-apple
as code owners
compnerd
approved these changes
Dec 16, 2025
etcwilde
approved these changes
Dec 16, 2025
Contributor
Author
|
@swift-ci please smoke test |
Member
|
@swift-ci please test Windows platform |
Bigcheese
approved these changes
Dec 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use-external-namesneeds to be true in the overlay file, otherwise the incremental build will not work. If the value is false, the dependency scanner is reporting virtual path as dependency, thus build system cannot correctly validate if the dependencies are up-to-date since it does not know the on disk representation.