-
Notifications
You must be signed in to change notification settings - Fork 10.6k
🍒 utils: Update the bootstrap Windows toolchain #86110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/6.3
Are you sure you want to change the base?
🍒 utils: Update the bootstrap Windows toolchain #86110
Conversation
The current Windows arm64 bootstrap toolchain is not functional. (cherry picked from commit 29eecbe)
|
@swift-ci please test |
|
cc @Steelskin I'm not able to add you as a reviewer. EDIT: I was able to do it after refreshing the page. |
Steelskin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
@charles-zablit the change itself is fine, but I would appreciate a bit more information in the CCC. The motivation here is that the ARM64 builds require the update, which is why this change is worth bringing into the release. |
I updated the CCC to add more details. |
|
@swift-ci please test macos |
Explanation:
The current ARM64 pinned toolchain does not work (
swiftcdoes not run), therefore building on an ARM64 machine currently does not work. This patch updates the Windows bootstrap toolchains to a working one, which fixes the build.Scope:
This change impacts the Swift toolchain build script on Windows.
Issues:
Original PRs:
Risk:
Low, this updates from one snapshot to the next.
Testing:
Built at desk on an ARM64 Windows VM.
Reviewers: