feat(internet-header): allow to use p tags instead of heading tags #5907
Conversation
Added the possibility to use paragraphs instead of headings for the post-header component. This enables project to fully control the heading structure of the document.
🦋 Changeset detectedLatest commit: b8309b3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
Related Previews |
| <p slot="megadropdown-title" class="h2">Briefe title</p> | ||
| <post-list> | ||
| <h3>Briefe senden</h3> | ||
| <p class="h3">Briefe senden</p> |
There was a problem hiding this comment.
I feel it's a bit dangerous to let people put whichever class they want here. In our CSS for instance, we set .megadropdown h2, .megadropdown > h2 to display: none and letting users choose which title size they want might result in a hidden title. Also, it opens the possibility for users to derive from the intended design.
What do you think? Should we skip those classes and target the "fake" headings another way in CSS?
| table: { | ||
| category: 'Content', | ||
| }, | ||
| defaultValue: { summary: true }, |
There was a problem hiding this comment.
This value is not shown in the arguments table, also is there really a default value here?
|
Added the possibility to use paragraphs instead of headings for the post-header component. This enables project to fully control the heading structure of the document.