-
-
Notifications
You must be signed in to change notification settings - Fork 674
Move discogs-bundle 4.0 config to packages directory #1886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move discogs-bundle 4.0 config to packages directory #1886
Conversation
|
Thanks for the PR 😍 How to test these changes in your application
Diff between recipe versionsIn order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request updates the discogs-bundle 4.0 recipe to follow modern Symfony bundle standards by ensuring configuration files are placed in the config/packages/ directory. However, there is an issue with the implementation.
- Updates the manifest.json copy-from-recipe path
- Adds a new configuration file at config/packages/calliostro_discogs.yaml
Reviewed Changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| calliostro/discogs-bundle/4.0/manifest.json | Modified the copy-from-recipe path to include packages/ subdirectory |
| calliostro/discogs-bundle/4.0/config/packages/calliostro_discogs.yaml | Added configuration file with authentication and rate limiting options |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
- Remove # prefix to make env variable available in .env file - Fixes inconsistency between YAML config and manifest - Thanks @diimpp for catching this issue
Head branch was pushed to by a user without write access
Update discogs-bundle 4.0 recipe to follow modern Symfony bundle standards.