Skip to content

Conversation

@calliostro
Copy link
Contributor

Q A
License MIT
Packagist https://packagist.org/packages/calliostro/discogs-bundle

Update discogs-bundle 4.0 recipe to follow modern Symfony bundle standards.

  • Move config file to packages/ directory

Copilot AI review requested due to automatic review settings November 17, 2025 19:25
@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) November 17, 2025 19:25
@github-actions
Copy link

github-actions bot commented Nov 17, 2025

Thanks for the PR 😍

How to test these changes in your application

  1. Define the SYMFONY_ENDPOINT environment variable:

    # On Unix-like (BSD, Linux and macOS)
    export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1886/index.json
    # On Windows
    SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1886/index.json
  2. Install the package(s) related to this recipe:

    composer req symfony/flex
    composer req 'calliostro/discogs-bundle:^4.0'
  3. Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

    # On Unix-like (BSD, Linux and macOS)
    unset SYMFONY_ENDPOINT
    # On Windows
    SET SYMFONY_ENDPOINT=

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes.
I'm going keep this comment up to date with any updates of the attached patch.

Copilot finished reviewing on behalf of calliostro November 17, 2025 19:27
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request updates the discogs-bundle 4.0 recipe to follow modern Symfony bundle standards by ensuring configuration files are placed in the config/packages/ directory. However, there is an issue with the implementation.

  • Updates the manifest.json copy-from-recipe path
  • Adds a new configuration file at config/packages/calliostro_discogs.yaml

Reviewed Changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

File Description
calliostro/discogs-bundle/4.0/manifest.json Modified the copy-from-recipe path to include packages/ subdirectory
calliostro/discogs-bundle/4.0/config/packages/calliostro_discogs.yaml Added configuration file with authentication and rate limiting options

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

auto-merge was automatically disabled November 17, 2025 19:28

Head branch was pushed to by a user without write access

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) November 17, 2025 19:28
auto-merge was automatically disabled November 17, 2025 19:31

Head branch was pushed to by a user without write access

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) November 17, 2025 19:32
auto-merge was automatically disabled November 17, 2025 22:04

Head branch was pushed to by a user without write access

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) November 17, 2025 22:05
auto-merge was automatically disabled November 17, 2025 22:10

Head branch was pushed to by a user without write access

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) November 17, 2025 22:10
- Remove # prefix to make env variable available in .env file
- Fixes inconsistency between YAML config and manifest
- Thanks @diimpp for catching this issue
auto-merge was automatically disabled November 20, 2025 13:03

Head branch was pushed to by a user without write access

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) November 20, 2025 13:03
@symfony-recipes-bot symfony-recipes-bot merged commit ccddb71 into symfony:main Nov 20, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants