refactor: replace koa-connect with custom middleware adapter #622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: be37ff5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
o-alexandrov
force-pushed
the
modernize-koa-connect
branch
2 times, most recently
from
c4f6e34 to
c49c0db
Compare
Remove the koa-connect dependency in favor of a lightweight custom implementation. The new connectToKoa adapter provides the same functionality for bridging Vite's Connect-style middleware to Koa, with comprehensive documentation and support for Vite 4.x-7.x.
o-alexandrov
force-pushed
the
modernize-koa-connect
branch
from
c49c0db to
99edf81
Compare
Contributor
Author
|
@tajo this PR is ready for review, when it'd be convenient for you. |
Contributor
Author
|
@tajo could you please review this PR? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace koa-connect with custom middleware adapter
Motivation
ladledoesn't work because ofkoa-connectwhen running using tsxChanges
lib/cli/vite-plugin/connect-to-koa.js- Custom middleware adapter with detailed JSDoc documentationlib/cli/vite-dev.js- Replacedkoa-connectimport with customconnectToKoafunctionkoa-connectfrompackage.jsondependencies