forked from NVIDIA/Megatron-LM
-
Notifications
You must be signed in to change notification settings - Fork 0
Tde/fix sampling tensorize #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tdene
wants to merge
38
commits into
tmp_main
Choose a base branch
from
tde/fix_sampling_tensorize
base: tmp_main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
78fa9c8 to
d4d4f6f
Compare
6 tasks
d4d4f6f to
f27823f
Compare
Co-authored-by: Shanmugam Ramasamy <[email protected]> Co-authored-by: Teodor-Dumitru Ene <[email protected]> Co-authored-by: oliver könig <[email protected]>
Co-authored-by: Jon Barker <[email protected]>
Co-authored-by: Jon Barker <[email protected]>
Signed-off-by: kunlunl <[email protected]> Co-authored-by: Eric Harper <[email protected]>
Signed-off-by: oliver könig <[email protected]>
f27823f to
c7124fe
Compare
Co-authored-by: Jon Barker <[email protected]>
c7124fe to
bffbb99
Compare
Signed-off-by: Pablo Garay <[email protected]>
Co-authored-by: Jon Barker <[email protected]>
bffbb99 to
219f5fd
Compare
… match old version (NVIDIA#2540) Co-authored-by: Jon Barker <[email protected]>
591ea51 to
62d6d5d
Compare
…re change) (NVIDIA#2543) Signed-off-by: Pablo Garay <[email protected]>
Signed-off-by: Pablo Garay <[email protected]>
Signed-off-by: oliver könig <[email protected]>
Co-authored-by: root <[email protected]> Co-authored-by: root <[email protected]> Co-authored-by: root <[email protected]> Co-authored-by: root <[email protected]> Co-authored-by: root <[email protected]> Co-authored-by: root <[email protected]>
Signed-off-by: oliver könig <[email protected]>
Signed-off-by: oliver könig <[email protected]>
Signed-off-by: oliver könig <[email protected]>
Signed-off-by: oliver könig <[email protected]>
…2561) Signed-off-by: oliver könig <[email protected]>
Co-authored-by: Xin Yao <[email protected]> Co-authored-by: oliver könig <[email protected]>
…A#1860) Co-authored-by: Xin Yao <[email protected]>
83c5f69 to
f2a0f18
Compare
Signed-off-by: oliver könig <[email protected]>
Signed-off-by: Keith Wyss <[email protected]>
Signed-off-by: dimapihtar <[email protected]>
c6cc656 to
5b2bb81
Compare
Signed-off-by: Keith Wyss <[email protected]> Co-authored-by: Cyril Meurillion <[email protected]>
… to a multiple of TP (NVIDIA#2574) Co-authored-by: Jon Barker <[email protected]>
5b2bb81 to
45ab5a7
Compare
45ab5a7 to
b80a874
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Contribution process
flowchart LR A[Pre-checks] --> B[PR Tests] subgraph Code Review/Approval C1[Expert Review] --> C2[Final Review] end B --> C1 C2 --> D[Merge]Pre-checks
Core 0.8)Code review
The following process is enforced via the CODEOWNERS file for changes into
megatron/core. For changes outside ofmegatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.For MRs into `main` branch
(Step 1): Add PR label
Expert Review(Step 2): Collect the expert reviewers reviews
Expert Reviewlabel when your PR is ready for review.Final Review might get declined if these requirements are not fulfilled.
(Step 3): Final Review
Final Reviewlabel(Optional Step 4): Cherry-pick into release branch
If this PR also needs to be merged into
core_r*release branches, after this PR has been merged, selectCherry-pickto open a new PR into the release branch.For MRs into `dev` branch
The proposed review process for `dev` branch is under active discussion.MRs are mergable after one approval by either
[email protected]or[email protected].Merging your PR
Any member of core-adlr and
core-nemowill be able to merge your PR.