feat(database): add foreign key support for sqlite dialect #1832
+24
−39
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1830
This PR adds foreign key support for SQLite dialect (cf. https://sqlite.org/foreignkeys.html for specification).
Changes
The following code now successfully creates a foreign key with sqlite:
At first, it didn't work because in SQLite, foreign keys must be defined after table columns.
So I used the
sortByCallbackfunction on the statements array in order to make sure that foreign keys are always defined at the end of the create table statement.Limitations
The following code fails (QueryWasInvalid exception):
This is perfectly normal because it is not possible to add a foreign key on an existing table in sqlite.
It would be better if tempest threw a DialectWasNotSupported exception, but I'm not sure if it's possible to implement easily, because the BelongsToStatement is wrapped inside a AlterAddColumnStatement object.
Warning
I updated the unit tests but I didn't do a lot of real world testing.
I only tested a migration with a create statement and an alter statement.