-
-
Notifications
You must be signed in to change notification settings - Fork 31
feat!: Upgrade AWS provider and min required Terraform version to 6.19 and 1.5.7 respectively
#45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…2` and `1.5.7` respectively
…ty_group_ingress_rule`/`aws_vpc_security_group_egress_rule` resources
…ffered by provider
6.2 and 1.5.7 respectively6.19 and 1.5.7 respectively
antonbabenko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, minor things
docs/UPGRADE-3.0.md
Outdated
| # Only the affected attributes are shown | ||
|
|
||
| # Copy and paste from output to maintain backwards compatibility | ||
| # This was added by the AWS Redshift API and provider in v6.x |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Redshift?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
too many modules at once 😅 - corrected in e6b4943
Co-authored-by: Anton Babenko <[email protected]>
## [3.0.0](v2.4.3...v3.0.0) (2025-11-14) ### ⚠ BREAKING CHANGES * Upgrade AWS provider and min required Terraform version to `6.19` and `1.5.7` respectively (#45) ### Features * Upgrade AWS provider and min required Terraform version to `6.19` and `1.5.7` respectively ([#45](#45)) ([a674683](a674683))
|
This PR is included in version 3.0.0 🎉 |
Description
List of backwards incompatible changes
v1.5.7is now minimum supported versionv6.19is now minimum supported versionv2.38is now minimum supported version (EMR on EKS virtual cluster sub-module)aws_security_group_ruleresources have been split intoaws_vpc_security_group_ingress_ruleandaws_vpc_security_group_egress_ruleresources to better match the AWS API and allow for more flexibility in defining security group rules. Prior variable names of*_security_group_ruleshave been split into*_security_group_ingress_rulesand*_security_group_egress_rulesto match.Additional changes
Added
regionparameter to specify the AWS region for the resources created if different from the provider region.Modified
objecttypes in place of the previously used any type.createflags to prevent unnecessary API calls.release_label_filters.prefixnow defaults toemr-7, was previouslyemr-6.unhealthy_node_replacementnow defaults totrueaws_service_principaldata source is now used to fetch the correct service principals (instead of trying to construct them psuedo-manually with the DNS suffix).Variable and output changes
Removed variables:
serverlesssub-modulestudiosub-modulevirtual_clustersub-moduleRenamed variables:
master_security_group_rules->master_security_group_ingress_rulesandmaster_security_group_egress_rulesslave_security_group_rules->slave_security_group_ingress_rulesandslave_security_group_egress_rulesservice_security_group_rules->service_security_group_ingress_rulesandservice_security_group_egress_rulesserverlesssub-modulesecurity_group_rules->security_group_ingress_rulesandsecurity_group_egress_rulesrelease_label_prefix->release_label_filtersstudiosub-moduleengine_security_group_rules->engine_security_group_ingress_rulesandengine_security_group_egress_rulesworkspace_security_group_rules->workspace_security_group_ingress_rulesandworkspace_security_group_egress_rulesvirtual_clustersub-moduleeks_cluster_id->eks_cluster_nameto better match API of EKS module/resourcesoidc_provider_arn->eks_oidc_provider_arnfor clarity to show its related to EKS authenticationAdded variables:
os_release_labelserverlesssub-modulemonitoring_configurationruntime_configurationscheduler_configurationstudiosub-modulevirtual_clustersub-modulecloudwatch_log_group_classMotivation and Context
Breaking Changes
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request