-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
feat: Add variable create_lambda_permission in notification module #302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
antonbabenko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea, but let's rename var from create_lambda_policy to create_lambda_permission since Lambda has permissions, but SNS/SQS has policies.
|
This doesn't seem like a breaking change, since |
I realized you're right! |
I renamed it to |
## [4.4.0](v4.3.0...v4.4.0) (2025-01-13) ### Features * Add variable create_lambda_permission in notification module ([#302](#302)) ([5b71671](5b71671))
|
This PR is included in version 4.4.0 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
In the Notification module create a new variable a new
create_lambda_policythat functions similar tocreate_sqs_policyandcreate_sns_policyMotivation and Context
I define and manage my Lambda Policy separate from the Terraform where I manage my S3 Notifications. I don't want this module to force me to manage the Lambda policy here.
Fixes #301
Breaking Changes
I think that migrating
aws_lambda_permission.allowfrom a single to acountthis will cause the Resource to be recreated.This can be avoided by performing
terraform state mvThere are 3 types of notifications, and this change brings Lambda in line with SQS and SNS that support
create_sqs_policyandcreate_sns_policyHow Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request