feat: include custom vpc endpoints

[vitalieji]

No description provided.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vitalieji
Once this PR has been reviewed and has the lgtm label, please assign enriquebelarte for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

Hi @vitalieji. Thanks for your PR.

I'm waiting for a terraform-redhat member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[hunterkepley]

/ok-to-test

[hunterkepley]

@vitalieji This MR looks great, thanks for submitting this 🙂

To get the tests passing there's a couple things that need to be changed;

• MR title needs to have the following format: TICKETORISSUE-12345 | feat: ..... For example, ISS-71 | feat: Include custom vpc endpoints
• make terraform-docs needs to be ran
• The commit msg must also have the same format as the MR title (generally we use the same text)

Thanks again 🙂

[vitalieji]

@vitalieji This MR looks great, thanks for submitting this 🙂

To get the tests passing there's a couple things that need to be changed;

• MR title needs to have the following format: TICKETORISSUE-12345 | feat: ..... For example, ISS-71 | feat: Include custom vpc endpoints
• make terraform-docs needs to be ran
• The commit msg must also have the same format as the MR title (generally we use the same text)

Thanks again 🙂

[openshift-ci]

@vitalieji: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/verify-gen	682f61e	link	true	/test verify-gen
ci/prow/rosa-hcp-public	682f61e	link	true	/test rosa-hcp-public
ci/prow/rosa-hcp-private	682f61e	link	true	/test rosa-hcp-private

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[hunterkepley]

Thanks! Looks like a test failure is happening;

Container test exited with code 2, reason Error
---
.validations will be created
  + resource "null_resource" "validations" {
      + id = (known after apply)
    }
 Plan: 3 to add, 0 to change, 0 to destroy.
 Changes to Outputs:
  + password = (sensitive value)
╷
│ Error: Invalid provider configuration
│ 
│ Provider "registry.terraform.io/hashicorp/aws" requires explicit
│ configuration. Add a provider block to the root module and configure the
│ provider's required arguments as described in the provider documentation.
│ 
╵
╷
│ Error: Retrieving AWS account details: validating provider credentials: retrieving caller identity from STS: operation error STS: GetCallerIdentity, https response error StatusCode: 403, RequestID: 4ea439c8-78f0-43f3-89d1-d3adb4c3693a, api error InvalidClientTokenId: The security token included in the request is invalid.
│ 
│   with provider["registry.terraform.io/hashicorp/aws"],
│   on <empty> line 0:
│   (source code not available)
│ 
╵
"terraform apply" failed
Running "terraform destroy" ...