Updated type generattions and fix search types #4819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgrimm
reviewed
Nov 26, 2025
| { | ||
| operation: 'field', | ||
| field: fields[2], | ||
| type: 'Exact', |
Contributor
There was a problem hiding this comment.
This shouldn't be needed. Exact is the default. Looks like the bug here is that the default isn't indicated in the OpenAPI schema, which we should fix on the server side.
Contributor
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing
SearchNodePayloadgenerated by theopenapi-typescriptpackage was overriden with[key: string]: any;in the payload, which means that any of our usages essentially by passed all type safety and checks. We had more than a few incorrect usages as a result.This PR fixes the typescript by fixing the generated types and resolving the differences. This PR is necessary for moving Search APIs to utilize Redux RTK instead.
Most changes simply enforce some stronger type-checking without any functional changes.
In a few places, memoizations are added to ensure correctness.
For all of our search filters, since the resulting payloads are wrapped around with an
AndNodePayload, they were updated to beFieldNodePayload[]directly to enforce the flat structure as well as eliminate some type ambiguity.