Issue#58: Define colours and fonts #60
Conversation
|
Visit the preview URL for this PR (updated for commit bb47f4d): https://tcl-77-smart-shopping-list--pr60-fz-design-home-page-69wvm364.web.app (expires Tue, 15 Oct 2024 01:02:14 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: b77df24030dca7d8b6561cb24957d2273c5e9d72 |
zahrafalak
requested review from
RossaMania,
adidalal,
alex-andria,
bbland1,
eternalmaha and
tannaurus
| $grey: #525252; | ||
| $primary-beige: #f1e6cc; | ||
| $primary-blue: #3f6476; | ||
| $secondary-blue: #001f3f; |
There was a problem hiding this comment.
non-blocking because I realizes I don't remember if the 3rd blue is used at all but there is one more color in the design incase we want to add it in this push
#356481
There was a problem hiding this comment.
PRAISE: Three colors are good to start with (some palette websites generate palettes of four, five or more colors)! I like how we are getting rid of white!
There was a problem hiding this comment.
Yeah I didn't see the fourth colour used in any of the elements, so didn't add it in. But we can definitely add that later on if needed.
|
|
||
| import "bootstrap/dist/css/bootstrap.min.css"; | ||
| import "./index.scss"; | ||
| import "./styles/global.scss"; |
There was a problem hiding this comment.
question: is this just the base styling of the app basically?
| crossorigin="anonymous" | ||
| /> | ||
| <link rel="preconnect" href="https://fonts.googleapis.com" /> | ||
| <link rel="preconnect" href="https://fonts.gstatic.com" crossorigin /> |
There was a problem hiding this comment.
PRAISE: Nice job importing the Google Font using the link element. The other way(s) I can remember to import Google Fonts can make things ....non-non-heinous!
| font-weight: 400; | ||
| font-style: normal; | ||
| background-color: $primary-beige; | ||
| } |
There was a problem hiding this comment.
PRAISE: Ooooh! The start of a style sheet--one of the things I like about SCSS!
##Summary
We have decided on a colour palette and fonts for our app. We now have to integrate those into the app, so we can start the design process.
closes #58
##Acceptance Criteria
variables.scsspartial.Before
After