Skip to content

Conversation

@tianon
Copy link
Owner

@tianon tianon commented Nov 26, 2024

Clamped to officially update once per week, but written such that a BUILDKIT_COMMIT build-arg can build any commit.

@tianon
Copy link
Owner Author

tianon commented Nov 26, 2024

Example of the tagging change this produces:

Diff:
$ diff -u <(bashbrew cat https://github.com/tianon/bashbrew-tianon/raw/HEAD/library/buildkit) <(bashbrew cat <(./gsl.sh))
--- /dev/fd/63	2024-11-25 23:11:00.770073134 -0800
+++ /dev/fd/62	2024-11-25 23:11:00.770073134 -0800
@@ -1,7 +1,7 @@
 Maintainers: Tianon Gravi <[email protected]> (@tianon)
 Architectures: amd64, arm32v5, arm32v7, arm64v8, i386, mips64le, ppc64le, riscv64, s390x
 GitRepo: https://github.com/tianon/dockerfiles.git
-GitCommit: 474407be6cfd8423efd92bd3dbc4f5676e8b2600
+GitCommit: 6a524aa3d738d3625038ea9cb820ccdd5639ca2e
 Directory: buildkit
 Builder: buildkit
 
@@ -15,3 +15,6 @@
 
 Tags: 0.13.2, 0.13
 File: Dockerfile.0.13
+
+Tags: dev-20241123-114946, dev-20241123, dev-787d9d078a3c4083d5f69f51a228151d61f969fe, dev-787d9d0, dev
+File: Dockerfile.dev

@tianon
Copy link
Owner Author

tianon commented Nov 26, 2024

The biggest downside to this is that https://github.com/docker-library/bashbrew/blob/f71d6ef63e1f5abe6d5cb06a62a3e5e42d68566e/pkg/tarscrub/tarscrub.go#L10 is not implemented yet, so every update to this means a rebuild to all the other variants of tianon/buildkit also 😞

@tianon
Copy link
Owner Author

tianon commented Nov 26, 2024

(see also docker-library/golang#531, which is where I first figured out this "clamping" technique)

Clamped to officially update once per week, but written such that a BUILDKIT_COMMIT build-arg can build any commit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant