Add migration to/from WAL-based invalidation #8738
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkindahl
force-pushed
the
cagg-wal-inval-migrate
branch
4 times, most recently
from
d340002 to
4ae0ecc
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8738 +/- ##
==========================================
- Coverage 82.48% 80.89% -1.59%
==========================================
Files 247 247
Lines 47591 47483 -108
Branches 12114 12061 -53
==========================================
- Hits 39254 38412 -842
- Misses 3474 4244 +770
+ Partials 4863 4827 -36 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mkindahl
force-pushed
the
cagg-wal-inval-migrate
branch
2 times, most recently
from
92ecc1b to
b2f122b
Compare
To support migration from trigger-based invalidation collection to WAL-based invalidation collection, or the opposite, the function `_timescaledb_functions.set_invalidation_method` is introduced. When called with a hypertable (that has continuous aggregates connected) and an invalidation method, it will flush the hypertable invalidations and changes the collection method for the hypertable to use the requested one. It will changes the collection method for *all* continuous aggregates connected to the given hypertable, not just for a single continuous aggregate. Also adds tests for the migration to check that it works properly.
mkindahl
force-pushed
the
cagg-wal-inval-migrate
branch
from
b2f122b to
4732998
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support migration from trigger-based invalidation collection to WAL-based invalidation collection, or the opposite, the function
_timescaledb_functions.set_invalidation_methodis introduced. When called with a hypertable (that has continuous aggregates connected) and an invalidation method, it will flush the hypertable invalidations and changes the collection method for the hypertable to use the requested one.It will changes the collection method for all continuous aggregates connected to the given hypertable, not just for a single continuous aggregate.
Also adds tests for the migration to check that it works properly.