Skip to content

Fix RELEASE_TAG for git tag population: #494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 24, 2025
Merged

Fix RELEASE_TAG for git tag population: #494

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
218292a
Fix RELEASE_TAG for git tag population:
jacobweinstock Sep 24, 2025
acb26c8
Merge branch 'main' into fix-release
mergify[bot] Sep 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,14 +159,25 @@ set-manifest-image:
## Release
## --------------------------------------

RELEASE_TAG := $(shell git describe --abbrev=0 2>/dev/null)
# When running in GitHub Actions for a tag, use the tag name from GITHUB_REF
# Otherwise, fall back to git describe to find the latest tag
ifdef GITHUB_REF
ifeq ($(findstring refs/tags/,$(GITHUB_REF)),refs/tags/)
RELEASE_TAG := $(shell echo $(GITHUB_REF) | sed -e 's/refs\/tags\///')
else
RELEASE_TAG := $(shell git describe --abbrev=0 2>/dev/null)
endif
else
RELEASE_TAG := $(shell git describe --abbrev=0 2>/dev/null)
endif
RELEASE_DIR ?= out/release

$(RELEASE_DIR):
mkdir -p $(RELEASE_DIR)/

.PHONY: release
release: clean-release
@echo "Using RELEASE_TAG: $(RELEASE_TAG)"
$(MAKE) set-manifest-image MANIFEST_IMG=$(REGISTRY)/$(IMAGE_NAME) MANIFEST_TAG=$(RELEASE_TAG)
$(MAKE) release-manifests
$(MAKE) release-metadata
Expand Down