Skip to content

Conversation

@GideonBear
Copy link
Member

@GideonBear GideonBear commented Aug 8, 2025

What does this PR do

  • Still print summary when (q)uit is used
  • Make sure the report is still added for a step when (q)uit is used
  • Remove unused interrupted argument

Standards checklist

  • The PR title is descriptive
  • I have read CONTRIBUTING.md
  • Optional: I have tested the code myself
  • If this PR introduces new user-facing messages they are translated

@GideonBear GideonBear changed the title Still print summary when (q)uit is used feat: still print summary when (q)uit is used Oct 13, 2025
@GideonBear
Copy link
Member Author

This also fixes there not being a newline after pressing q:

Retry? (y)es/(N)o/(s)hell/(q)uit[gideon@gideon-pc-lin ~/projects/topgrade] (main =) 1 (4.321s)

@GideonBear GideonBear changed the title feat: still print summary when (q)uit is used feat: print summary when (q)uit is used Nov 15, 2025
@GideonBear GideonBear changed the title feat: print summary when (q)uit is used feat: print summary and run post commands when (q)uit is used Nov 15, 2025
@GideonBear
Copy link
Member Author

GideonBear commented Nov 15, 2025

This does not solve the issue where pressing Ctrl+C on the prompt continues execution normally:

Retry? (y)es/(N)o/(s)hell/(q)uitERROR Error reading from terminal: read interrupted


── 10:02:29 - uv ───────────────────────────────────────────────────────────────

But that was already there, this behavior is unchanged.

@GideonBear GideonBear merged commit 639d055 into topgrade-rs:main Nov 15, 2025
17 checks passed
@GideonBear GideonBear deleted the print-summary-on-quit branch November 15, 2025 09:03
@github-actions github-actions bot mentioned this pull request Nov 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant