feat(git): add option to fetch instead of pull repositories #1371
Conversation
|
I added "closes #806" to make sure GitHub understands that it closes that issue |
| "Pulling": | ||
| en: "Pulling" | ||
| lt: "Traukiama" | ||
| es: "Extrayendo" | ||
| fr: "Récupération" | ||
| zh_CN: "正在拉取" | ||
| zh_TW: "正在拉取" | ||
| de: "Abrufen" | ||
| "Fetching": | ||
| en: "Fetching" | ||
| lt: "Gaunama" | ||
| es: "Obteniendo" | ||
| fr: "Récupération" | ||
| zh_CN: "正在获取" | ||
| zh_TW: "正在獲取" | ||
| de: "Abrufen" |
There was a problem hiding this comment.
Some of these overlap (fr, zh*, de). Is there some translated Git documentation that you can reference?
There was a problem hiding this comment.
I could have a look but this is just Claude translated
| let result = if is_fetch_only { | ||
| output_checked_utf8(pull_or_fetch_output) | ||
| } else { |
There was a problem hiding this comment.
Particular reason we don't want to git submodule update --recursive in fetch_only? Is there some kind of git submodule fetch --recursive?
There was a problem hiding this comment.
It was suggested in the original PR. What do we think of git submodule foreach --recursive git fetch?
There was a problem hiding this comment.
How about just git fetch --recurse-submodules? Can we use git pull --ff-only --recurse-submodules as well, instead of a seperate git submodule update --recursive call? Or is there a difference?
fix let declaration Co-authored-by: Gideon <[email protected]>
| let result = if is_fetch_only { | ||
| output_checked_utf8(pull_or_fetch_output) | ||
| } else { |
There was a problem hiding this comment.
How about just git fetch --recurse-submodules? Can we use git pull --ff-only --recurse-submodules as well, instead of a seperate git submodule update --recursive call? Or is there a difference?
| # ] | ||
|
|
||
| # Don't pull the predefined git repos | ||
| # Don't pull/fetch the predefined git repos |
There was a problem hiding this comment.
Not your code, but this is a bit confusing
| # Don't pull/fetch the predefined git repos | |
| # Set to `false` to skip pulling/fetching the predefined git repos |
|
Aaaah GitHub review is confusing... Sorry if a comment is duplicated or out of place |
GideonBear
changed the title
GideonBear
changed the title
|
Hi, do you have any idea when you're able to work on this again? |
2 participants
Continuation of #918
Closes #806
New PR since I deleted my old fork :D. Also includes improvements based on original comments.
What does this PR do
add fetch_only to config in case user wants to only fetch, not already pull changes
Standards checklist
CONTRIBUTING.mdFor new steps
--dry-runoption works with this step--yesoption works with this step if it is supported bythe underlying command
If you developed a feature or a bug fix for someone else and you do not have the
means to test it, please tag this person here.