Skip to content

Commit 6088528

Browse files
committed
Merge #1305: docs: remove code-review comment
bc95fc4 docs: remove code-review comment (Jose Celano) Pull request description: We decided not to change it. - The returned value is simpler. - We force the initial peer to change so there is no confusion about what was the final announced peer. ACKs for top commit: josecelano: ACK bc95fc4 Tree-SHA512: 0973cc3ffed75befc8803c7e63271566f3a1c2046b631b42d67be8aa0cb674b06e63295b6d4c1a8f2b95a951ac8b9792564161388e90a2d518342b2faf9dd97b
2 parents fd6e902 + bc95fc4 commit 6088528

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

packages/tracker-core/src/announce_handler.rs

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -162,10 +162,6 @@ impl AnnounceHandler {
162162
remote_client_ip: &IpAddr,
163163
peers_wanted: &PeersWanted,
164164
) -> Result<AnnounceData, AnnounceError> {
165-
// code-review: maybe instead of mutating the peer we could just return
166-
// a tuple with the new peer and the announce data: (Peer, AnnounceData).
167-
// It could even be a different struct: `StoredPeer` or `PublicPeer`.
168-
169165
self.whitelist_authorization.authorize(info_hash).await?;
170166

171167
tracing::debug!("Before: {peer:?}");

0 commit comments

Comments
 (0)