Skip to content

docs: update a11y meta tags and favicon to correct values and match code-quality part #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 8, 2025
Merged

docs: update a11y meta tags and favicon to correct values and match code-quality part #332

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2dd84f4
docs: fix a11y meta title, description and update favicon to match co…
wo-o29 Aug 21, 2025
a034a18
fix: update favicon path and add favicon file
wo-o29 Aug 21, 2025
a0368ad
Merge branch 'main' into docs/update-a11y-meta-data-and-favicon
wo-o29 Sep 1, 2025
52f6125
[autofix.ci] apply automated fixes
autofix-ci[bot] Sep 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions fundamentals/a11y/.vitepress/shared.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ export const sharedConfig = defineConfig({
head: [
[
"link",
{ rel: "icon", type: "image/x-icon", href: "/images/favicon.ico" }
{ rel: "icon", type: "image/x-icon", href: "/a11y/images/favicon.ico" }
Copy link
Collaborator

@milooy milooy Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇

],
[
"meta",
Expand All @@ -59,11 +59,11 @@ export const sharedConfig = defineConfig({
transformHead: ({ pageData }) => {
const head: HeadConfig[] = [];
const title =
pageData.frontmatter.title || pageData.title || "Bundling Fundamentals";
pageData.frontmatter.title || pageData.title || "A11y Fundamentals";
Copy link
Collaborator

@milooy milooy Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

const description =
pageData.frontmatter.description ||
pageData.description ||
"Practical Guide to Efficient Frontend Bundling";
"Complete Guide to Frontend Accessibility";

head.push(["meta", { property: "og:title", content: title }]);
head.push(["meta", { property: "og:description", content: description }]);
Expand Down
Binary file added fundamentals/a11y/public/images/favicon.ico
View file
Open in desktop
Binary file not shown.
2 changes: 1 addition & 1 deletion fundamentals/code-quality/code/examples/item-edit-modal.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ function ItemEditModal({ open, items, recommendedItems, onConfirm, onClose }) {

return (
<Modal open={open} onClose={onClose}>
<ItemEditBody
<ItemEditBody
keyword={keyword}
onKeywordChange={setKeyword}
onClose={onClose}
Expand Down