Skip to content

refactor(TIL): detail page 리팩토링 #633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 4, 2025
Merged

refactor(TIL): detail page 리팩토링 #633

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
21a655b
refactor: detail page내 <PostDetail /> <WeeklyTop5 /> 컴포넌트 suspense +…
al-bur Nov 2, 2025
f4f3333
refactor: PostDetail 컴포넌트 내부 1차 리팩토링 할 것들 정리
al-bur Nov 2, 2025
1df9e69
wip
al-bur Nov 2, 2025
b90b5c8
refactor: 디테일 페이지내 컴포넌트 각각 분리
al-bur Nov 2, 2025
8b935c6
refactor: ContentBody 컴포넌트 리팩토링
al-bur Nov 2, 2025
00e16c2
feat: divider 복원
al-bur Nov 2, 2025
6a2a671
refactor: lint:fix
al-bur Nov 2, 2025
0d13d70
fix: prettier
al-bur Nov 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .pnp.cjs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions fundamentals/today-i-learned/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
"class-variance-authority": "^0.7.1",
"clsx": "^2.1.1",
"date-fns": "^4.1.0",
"es-toolkit": "^1.41.0",
"lucide-react": "^0.525.0",
"overlay-kit": "^1.8.4",
"react": "^18.2.0",
Expand Down
10 changes: 4 additions & 6 deletions fundamentals/today-i-learned/src/api/hooks/useDiscussions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import { useAuth } from "@/contexts/AuthContext";
import { ENV_CONFIG } from "@/utils/env";
import {
useInfiniteQuery,
useSuspenseQuery,
useMutation,
useQuery,
useQueryClient
Expand Down Expand Up @@ -122,12 +123,11 @@ export function useInfiniteDiscussions({
export function useWeeklyTopDiscussions({
owner = ENV_CONFIG.GITHUB_OWNER,
repo = ENV_CONFIG.GITHUB_REPO,
limit,
enabled = true
limit
}: Omit<UseDiscussionsParams, "categoryName"> & { limit?: number } = {}) {
const { user } = useAuth();

return useQuery({
return useSuspenseQuery({
queryKey: DISCUSSIONS_QUERY_KEYS.weekly(),
queryFn: async () => {
const discussions = await fetchWeeklyTopDiscussions({
Expand All @@ -137,7 +137,6 @@ export function useWeeklyTopDiscussions({
});
return limit ? discussions.slice(0, limit) : discussions;
},
enabled,
staleTime: 1000 * 60 * 30, // 30분
gcTime: 1000 * 60 * 60, // 1시간
retry: 1
Expand Down Expand Up @@ -240,14 +239,13 @@ export function useMyContributions({
export function useDiscussionDetail(id: string) {
const { user } = useAuth();

return useQuery({
return useSuspenseQuery({
queryKey: DISCUSSIONS_QUERY_KEYS.detail(id),
queryFn: () =>
fetchDiscussionDetail({
id,
accessToken: user?.accessToken
}),
enabled: !!id,
staleTime: 1000 * 60 * 5, // 5분
gcTime: 1000 * 60 * 30, // 30분
retry: 2
Expand Down
Loading