TIL > 카테고리 필터링 누락 코드 수정 및 categoryName => categoryId 마이그레이션 #659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- categoryName으로 categoryId를 불러오는 불필요한 과정 => categoryId를 이용해 api 호출 최소화 - categoryName을 하드코딩 => 상수로 분리 - 새로운 categoryId가 필요할때는 dev전용 페이지에서 쉽게 categoryId 얻기 - 메인테이너가 아니라서 기존 코드 리팩토링은 최대한 하지 않았습니다.
|
@yoonminsang is attempting to deploy a commit to the Toss Team on Vercel. A member of the Team first needs to authorize it. |
yoonminsang
changed the title
milooy
approved these changes
Nov 10, 2025
Collaborator
milooy
left a comment
milooy
left a comment
There was a problem hiding this comment.
민상님! Thank you for the contribution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Key Changes
http://localhost:5173/today-i-learned/dev-tools/category-id)에서 쉽게 categoryId 얻기🖼️ Before and After Comparison
/today-i-learned/dev-tools/category-id 신규 페이지
Before
After
