Skip to content

fix: useDebouncedCallback to support generic parameter type for onChange #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix: useDebouncedCallback to support generic parameter type for onChange #267

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7225c6a
fix: make useDebouncedCallback generic for flexible onChange paramete…
wo-o29 Sep 12, 2025
952ec41
fix: update onChange parameter type in useDebouncedCallback documenta…
wo-o29 Sep 12, 2025
ab03cd5
test: optimize debounce timing in useDebouncedCallback tests
wo-o29 Sep 12, 2025
7f7ece9
fix: update test cases in useDebouncedCallback to use correct values
wo-o29 Sep 14, 2025
f2d0f7a
fix: update onChange parameter type in useDebouncedCallback documenta…
wo-o29 Sep 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/hooks/useDebouncedCallback/ko/useDebouncedCallback.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ function useDebouncedCallback(options: Object): Function;
:nested="[
{
name: 'options.onChange',
type: 'Function',
type: '(newValue: T) => void',
required: true,
description: '디바운스할 콜백 함수예요.',
},
Expand Down
2 changes: 1 addition & 1 deletion src/hooks/useDebouncedCallback/useDebouncedCallback.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ function useDebouncedCallback(options: Object): Function;
:nested="[
{
name: 'options.onChange',
type: 'Function',
type: '(newValue: T) => void',
required: true,
description: 'The callback function to debounce.',
},
Expand Down
11 changes: 7 additions & 4 deletions src/hooks/useDebouncedCallback/useDebouncedCallback.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,17 +30,20 @@ type DebounceOptions = {
* return <input type="text" onChange={(e) => debouncedSetQuery(e.target.value)} />;
* }
*/
export function useDebouncedCallback({
export function useDebouncedCallback<T>({
onChange,
timeThreshold,
leading = false,
trailing = true,
}: DebounceOptions & {
onChange: (newValue: boolean) => void;
onChange: (newValue: T) => void;
timeThreshold: number;
}) {
const handleChange = usePreservedCallback(onChange);
const ref = useRef({ value: false, clearPreviousDebounce: () => {} });
const ref = useRef<{ value: T | null; clearPreviousDebounce: () => void }>({
value: null,
clearPreviousDebounce: () => {},
});

useEffect(() => {
const current = ref.current;
Expand All @@ -63,7 +66,7 @@ export function useDebouncedCallback({
}, [leading, trailing]);

return useCallback(
(nextValue: boolean) => {
(nextValue: T) => {
if (nextValue === ref.current.value) {
Copy link

Copilot AI Sep 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The strict equality comparison may not work correctly for object types. When T is an object, this comparison will check reference equality rather than value equality, potentially causing the debounce logic to fail. Consider using a deep equality check or allowing callers to provide a custom comparison function.

Copilot uses AI. Check for mistakes.
return;
}
Expand Down
Loading