Skip to content

refactor(Separated): fix key usage in Separated component: use child.key instead of array index for better stability #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

refactor(Separated): fix key usage in Separated component: use child.key instead of array index for better stability #278

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8385d8d
refactor: use unique child.key instead of array index as key in Separ…
wo-o29 Sep 15, 2025
e903eea
refactor: use fallback index for Fragment key in Separated component
wo-o29 Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/Separated/Separated.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ export function Separated({ children, by: separator }: Props) {
return (
<>
{childrenArray.map((child, i, { length }) => (
<Fragment key={i}>
<Fragment key={child.key}>
{child}
{i + 1 !== length && separator}
</Fragment>
Expand Down
Loading