-
Notifications
You must be signed in to change notification settings - Fork 134
Restrict Polyester.jl to v0.7.16 #2408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2408 +/- ##
=======================================
Coverage 96.95% 96.95%
=======================================
Files 504 504
Lines 41691 41721 +30
=======================================
+ Hits 40418 40448 +30
Misses 1273 1273
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
The remaining CI failures are again HTTP/2 429 errors:
and an error of the downgrade action: The only change of behavior in Polyester.jl comes from JuliaSIMD/Polyester.jl#154. |
|
Just a few rate limit errors. Let's see whether CI passes when running the two failing jobs again. However, the threaded CI jobs all pass 🥳 Thus, we have at least figured out what caused the errors - but fixing them may be tedious.... |
|
I will merge this right now without reviews to make CI work again. Please feel free to comment on it anyway. |
Let's see whether this influences the failing threaded CI tests