WIP: Sc/p4est view coupled hanging nodes #2598

SimonCan · 2025-10-09T13:34:23Z

Added capability of coupling pest mesh views with hanging/non-conforming nodes.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

There is still one part with hard-coded resolution, which needs to be changed.

general trees per dimension.

Removed unused code.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

…led-hanging-nodes

github-actions · 2025-11-20T16:24:07Z

test/test_p4est_2d.jl

+@trixi_testset "elixir_advection_coupled.jl" begin
+    @test_trixi_include(joinpath(EXAMPLES_DIR, "elixir_advection_coupled.jl"),
+                        l2=[0., 0.],
+                        linf=[0., 0.])
+#     Ensure that we do not have excessive memory allocations
+#     (e.g., from type instabilities)
+    @test_allocations(Trixi.rhs!, semi, sol, 135553)

    # Ensure we cover the calculation of the node coordinates
    node_coordinates = typeof(parent_mesh.tree_node_coordinates)(undef, 2,
                                                                 ntuple(_ -> length(parent_mesh.nodes),
                                                                        2)...,
-                                                                 length(mesh.cell_ids))
-    result = Trixi.calc_node_coordinates!(node_coordinates, mesh, parent_mesh.nodes)
-    @test parent_mesh.tree_node_coordinates == result
-
+                                                                 length(mesh1.cell_ids))
    # Load the mesh file for code coverage.
-    loaded_mesh = Trixi.load_mesh_serial(joinpath("out", "mesh.h5"); n_cells_max = 0,
+    loaded_mesh = Trixi.load_mesh_serial(joinpath("out", "mesh_1_000000000.h5"); n_cells_max = 0,
                                         RealT = typeof(parent_mesh).parameters[3])
 end


[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

@trixi_testset "elixir_advection_coupled.jl" begin

@test_trixi_include(joinpath(EXAMPLES_DIR, "elixir_advection_coupled.jl"),

l2=[0., 0.],

linf=[0., 0.])

# Ensure that we do not have excessive memory allocations

# (e.g., from type instabilities)

@test_allocations(Trixi.rhs!, semi, sol, 135553)

# Ensure we cover the calculation of the node coordinates

node_coordinates = typeof(parent_mesh.tree_node_coordinates)(undef, 2,

ntuple(_ -> length(parent_mesh.nodes),

2)...,

length(mesh.cell_ids))

result = Trixi.calc_node_coordinates!(node_coordinates, mesh, parent_mesh.nodes)

@test parent_mesh.tree_node_coordinates == result

length(mesh1.cell_ids))

# Load the mesh file for code coverage.

loaded_mesh = Trixi.load_mesh_serial(joinpath("out", "mesh.h5"); n_cells_max = 0,

loaded_mesh = Trixi.load_mesh_serial(joinpath("out", "mesh_1_000000000.h5"); n_cells_max = 0,

RealT = typeof(parent_mesh).parameters[3])

end

@trixi_testset "elixir_advection_coupled.jl" begin

@test_trixi_include(joinpath(EXAMPLES_DIR, "elixir_advection_coupled.jl"),

l2=[0.0, 0.0],

linf=[0.0, 0.0])

# Ensure that we do not have excessive memory allocations

# (e.g., from type instabilities)

@test_allocations(Trixi.rhs!, semi, sol, 135553)

github-actions · 2025-11-20T16:24:07Z

test/test_p4est_2d.jl

+                                0.024657539839658474,
+                                0.0,
+                                0.0,
+                                0.0,


[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

0.0,

0.98015167453983, 0.10475978783943254,

0.15551175906375883,

0.0,

github-actions · 2025-11-20T16:24:07Z

test/test_p4est_2d.jl

+                                0.0,
+                                0.0,
+                                0.0,
+                                0.0,


[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

0.0,

2.026208477271868e-5],

linf=[10.19496728149964, 18.23726813972206,

10.04367783820621,

0.0,

github-actions · 2025-11-20T16:24:07Z

test/test_p4est_2d.jl

+                                0.0098589277826056,
+                                0.011870558900297097,
+                                6.882386285170543e-6,
+                                0.024648257743835045
+                            ],
+                            linf=[0.013719847889148373,
+                                0.01678917375613853,
+                                2.933466212909218e-5,


[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

0.0098589277826056,

0.011870558900297097,

6.882386285170543e-6,

0.024648257743835045

],

linf=[0.013719847889148373,

0.01678917375613853,

2.933466212909218e-5,

19.63022306543678, 1.3952679820406384, 1.8716515525771589,

github-actions · 2025-11-20T16:24:07Z

test/test_p4est_2d.jl

+                                0.01678917375613853,
+                                2.933466212909218e-5,
+                                0.0,
+                                0.03429795097747568,


[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

0.03429795097747568,

0.0017266639582675424],

tspan=(0.0, 0.02))

# Ensure that we do not have excessive memory allocations

# (e.g., from type instabilities)

@test_allocations(Trixi.rhs!, semi, sol, 1000)

end

@trixi_testset "elixir_mhd_rotor_cfl_ramp.jl" begin

@test_trixi_include(joinpath(EXAMPLES_DIR, "elixir_mhd_rotor_cfl_ramp.jl"),

l2=[

0.45519051169507474,

0.8917985468745363,

0.8324681609772325,

github-actions · 2025-11-20T16:24:08Z

test/test_p4est_2d.jl

+                                0.0,
+                                0.03429795097747568,
+                                0.0,
+                                0.0,


[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

0.0,

0.9801426190285389,

0.10476233464125001,

0.15551270692826116,

0.0,

github-actions · 2025-11-20T16:24:08Z

test/test_p4est_2d.jl

+                                0.03429795097747568,
+                                0.0,
+                                0.0,
+                                0.0,


[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

0.0,

2.0201603821472296e-5

],

linf=[

10.196786739705292,

18.267539012179128,

10.046104290498878,

0.0,

github-actions · 2025-11-20T16:24:08Z

test/test_p4est_2d.jl

+                                0.0,
+                                0.0,
+                                0.0,
+                                0.0,


[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

0.0,

19.668302849210974,

1.395022093528294,

1.8717844606331189,

0.0,

github-actions · 2025-11-20T16:24:08Z

test/test_p4est_2d.jl

+                                0.01368217970493435,
+                                0.016790901855796785,
+                                3.091328454846926e-5,
+                                0.034236712653821444])
+        # Ensure we cover the calculation of the node coordinates
+        node_coordinates = typeof(parent_mesh.tree_node_coordinates)(undef, 2,
+                                                                     ntuple(_ -> length(parent_mesh.nodes),
+                                                                            2)...,
+                                                                     length(mesh1.cell_ids))


[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

0.01368217970493435,

0.016790901855796785,

3.091328454846926e-5,

0.034236712653821444])

# Ensure we cover the calculation of the node coordinates

node_coordinates = typeof(parent_mesh.tree_node_coordinates)(undef, 2,

ntuple(_ -> length(parent_mesh.nodes),

2)...,

length(mesh1.cell_ids))

0.001651262488701531

],

tspan=(0.0, 0.02))

# Ensure that we do not have excessive memory allocations

# (e.g., from type instabilities)

@test_allocations(Trixi.rhs!, semi, sol, 1000)

github-actions · 2025-11-20T16:24:11Z

test/test_p4est_2d.jl

[JuliaFormatter] _{reported by reviewdog 🐶}

Trixi.jl/test/test_p4est_2d.jl

Lines 17 to 31 in 5a11404

@trixi_testset "elixir_advection_basic.jl" begin

@test_trixi_include(joinpath(EXAMPLES_DIR, "elixir_advection_basic.jl"),

# Expected errors are exactly the same as with TreeMesh!

l2=[8.311947673061856e-6],

linf=[6.627000273229378e-5])

# Ensure that we do not have excessive memory allocations

# (e.g., from type instabilities)

@test_allocations(Trixi.rhs!, semi, sol, 1000)

semi32 = Trixi.trixi_adapt(Array, Float32, semi)

@test real(semi32.solver) == Float32

@test real(semi32.solver.basis) == Float32

@test real(semi32.solver.mortar) == Float32

# TODO: remake ignores the mesh itself as well

@test real(semi32.mesh) == Float64

end

github-actions · 2025-11-20T16:24:12Z

test/test_p4est_2d.jl

[JuliaFormatter] _{reported by reviewdog 🐶}

Trixi.jl/test/test_p4est_2d.jl

Lines 104 to 111 in 5a11404

@trixi_testset "elixir_advection_restart_amr.jl" begin

@test_trixi_include(joinpath(EXAMPLES_DIR, "elixir_advection_restart_amr.jl"),

l2=[2.869137983727866e-6],

linf=[3.8353423270964804e-5])

# Ensure that we do not have excessive memory allocations

# (e.g., from type instabilities)

@test_allocations(Trixi.rhs!, semi, sol, 1000)

end

github-actions · 2025-11-20T16:24:13Z

test/test_p4est_2d.jl

[JuliaFormatter] _{reported by reviewdog 🐶}

Trixi.jl/test/test_p4est_2d.jl

Lines 581 to 609 in 5a11404

@trixi_testset "elixir_mhd_alfven_wave.jl" begin

@test_trixi_include(joinpath(EXAMPLES_DIR, "elixir_mhd_alfven_wave.jl"),

l2=[1.0513414461545583e-5, 1.0517900957166411e-6,

1.0517900957304043e-6, 1.511816606372376e-6,

1.0443997728645063e-6, 7.879639064990798e-7,

7.879639065049896e-7, 1.0628631669056271e-6,

4.3382328912336153e-7],

linf=[4.255466285174592e-5, 1.0029706745823264e-5,

1.0029706747467781e-5, 1.2122265939010224e-5,

5.4791097160444835e-6, 5.18922042269665e-6,

5.189220422141538e-6, 9.552667261422676e-6,

1.4237578427628152e-6])

# Ensure that we do not have excessive memory allocations

# (e.g., from type instabilities)

let

t = sol.t[end]

u_ode = sol.u[end]

du_ode = similar(u_ode)

@test (@allocated Trixi.rhs!(du_ode, u_ode, semi, t)) < 1000

end

@trixi_testset "elixir_euler_mhd_coupled.jl" begin

@test_trixi_include(joinpath(EXAMPLES_DIR, "elixir_euler_mhd_coupled.jl"),

l2=[0.009862595305604965,

0.011874205535856063,

5.0185914245237475e-6,

0.0,

0.024657539839658474,

0.0,

github-actions · 2025-11-20T16:24:13Z

test/test_p4est_2d.jl

[JuliaFormatter] _{reported by reviewdog 🐶}

Trixi.jl/test/test_p4est_2d.jl

Lines 637 to 718 in 5a11404

end

@trixi_testset "elixir_mhd_alfven_wave_nonconforming.jl" begin

@test_trixi_include(joinpath(EXAMPLES_DIR,

"elixir_mhd_alfven_wave_nonconforming.jl"),

l2=[

0.0322570437144848,

0.03598284801272945,

0.03562228071357411,

0.05288641880143085,

0.040752873778199326,

0.04207276835260492,

0.04171391252403866,

0.05289242879893149,

0.0016038935411812223

],

linf=[

0.175984910510666,

0.13999726708245439,

0.13336032728399658,

0.21248359539637798,

0.133294808938885,

0.17934684696413217,

0.1831567822932948,

0.21575881133569155,

0.01967917976620703

],

tspan=(0.0, 0.25))

# Ensure that we do not have excessive memory allocations

# (e.g., from type instabilities)

@test_allocations(Trixi.rhs!, semi, sol, 1000)

end

@trixi_testset "elixir_mhd_rotor.jl" begin

@test_trixi_include(joinpath(EXAMPLES_DIR, "elixir_mhd_rotor.jl"),

l2=[0.4551839744017604, 0.8917986079085971, 0.832474072904728,

0.0,

0.98015167453983, 0.10475978783943254,

0.15551175906375883,

0.0,

2.026208477271868e-5],

linf=[10.19496728149964, 18.23726813972206,

10.04367783820621,

0.0,

19.63022306543678, 1.3952679820406384, 1.8716515525771589,

0.0,

0.0017266639582675424],

tspan=(0.0, 0.02))

# Ensure that we do not have excessive memory allocations

# (e.g., from type instabilities)

@test_allocations(Trixi.rhs!, semi, sol, 1000)

end

@trixi_testset "elixir_mhd_rotor_cfl_ramp.jl" begin

@test_trixi_include(joinpath(EXAMPLES_DIR, "elixir_mhd_rotor_cfl_ramp.jl"),

l2=[

0.45519051169507474,

0.8917985468745363,

0.8324681609772325,

0.0,

0.9801426190285389,

0.10476233464125001,

0.15551270692826116,

0.0,

2.0201603821472296e-5

],

linf=[

10.196786739705292,

18.267539012179128,

10.046104290498878,

0.0,

19.668302849210974,

1.395022093528294,

1.8717844606331189,

0.0,

0.001651262488701531

],

tspan=(0.0, 0.02))

# Ensure that we do not have excessive memory allocations

# (e.g., from type instabilities)

@test_allocations(Trixi.rhs!, semi, sol, 1000)

end

github-actions · 2025-11-25T18:58:29Z

src/semidiscretization/semidiscretization_coupled_p4est.jl

+    for i in 1:length(semis)
+        n_cells += size(semis[i].cache.elements.node_coordinates)[end]
+    end
+    parent_tree_node_coordinates = Array{Real, 2 + 2}(undef, 2, ntuple(_ -> 4, 2)..., n_cells)


[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

parent_tree_node_coordinates = Array{Real, 2 + 2}(undef, 2, ntuple(_ -> 4, 2)..., n_cells)

parent_tree_node_coordinates = Array{Real, 2 + 2}(undef, 2, ntuple(_ -> 4, 2)...,

n_cells)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

SimonCan and others added 30 commits May 30, 2025 12:01

Update src/meshes/p4est_mesh_view.jl

3eb0e3b

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Update src/meshes/p4est_mesh_view.jl

31d0391

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Update src/meshes/p4est_mesh_view.jl

8a01a6c

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Removed swap file.

3bfa483

Return -1 if element id is not part of this p4est mesh view.

9b02fa6

Update src/semidiscretization/semidiscretization_coupled_p4est.jl

c8a9270

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Update src/semidiscretization/semidiscretization_coupled_p4est.jl

f0dc832

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Update src/semidiscretization/semidiscretization_coupled_p4est.jl

939a1a0

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Update src/solvers/dgsem_p4est/dg_2d.jl

f067b98

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Update src/semidiscretization/semidiscretization_coupled_p4est.jl

6e04e18

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Update src/semidiscretization/semidiscretization_coupled_p4est.jl

2ce754d

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Update src/semidiscretization/semidiscretization_coupled_p4est.jl

4de4fda

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Cleaned up some of the coupling code for p4est mesh views.

676829a

There is still one part with hard-coded resolution, which needs to be changed.

Started to get the roight p4esh mesh view boundaries.

eee5388

Corrected calculation of periodic boundary neighbors.

fb335c7

Generalized the p4eest mesh view coupling so that it works for

b580bd0

general trees per dimension.

Movde routine for finding global neighbor ids.

d6ecc94

Changed funciton signature.

c1523f8

Generalized for arbitrary number of nodes.

96244b6

Removed unused code.

Merge branch 'main' into sc/p4est-view-coupled

87e0cf2

Update src/meshes/p4est_mesh_view.jl

213d7e2

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Update src/meshes/p4est_mesh_view.jl

0b1f8e3

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Update src/meshes/p4est_mesh_view.jl

4431260

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Update src/meshes/p4est_mesh_view.jl

211faab

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Update src/meshes/p4est_mesh_view.jl

a4cdf7b

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Update src/semidiscretization/semidiscretization_coupled_p4est.jl

626c3f1

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Update src/semidiscretization/semidiscretization_coupled_p4est.jl

a14ac96

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Update src/semidiscretization/semidiscretization_coupled_p4est.jl

7b01b1e

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Update src/meshes/p4est_mesh_view.jl

d039315

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Update src/semidiscretization/semidiscretization_coupled_p4est.jl

e17e7eb

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

SimonCan and others added 22 commits October 23, 2025 08:09

Merge branch 'main' into sc/p4est-view-coupled-hanging-nodes

67efa85

Fixed parsing error in 2d p4est test file.

716ca60

Merge branch 'main' into sc/p4est-view-coupled-hanging-nodes

4cbe837

Merge branch 'main' into sc/p4est-view-coupled-enhanced

026c25b

Merge branch 'main' into sc/p4est-view-coupled-enhanced

1061839

Merge branch 'main' into sc/p4est-view-coupled-hanging-nodes

2b94b79

Merge branch 'main' into sc/p4est-view-coupled-enhanced

876d835

Update examples/structured_2d_dgsem/test.jl

08fb6b3

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Merge branch 'main' into sc/p4est-view-coupled-hanging-nodes

f288625

Merge branch 'main' into sc/p4est-view-coupled-enhanced

e20c3be

Merge branch 'main' into sc/p4est-view-coupled-enhanced

9d5bd67

Merge branch 'main' into sc/p4est-view-coupled-enhanced

cbf4e71

Merge branch 'main' into sc/p4est-view-coupled-hanging-nodes

d7d67b2

Reintroduced excess memory test.

3659a9b

Corrected mesh file name.

1f52ea7

Merge branch 'main' into sc/p4est-view-coupled-enhanced

d7eb284

Corrected relative directory of the out fils for p4est coupled test.

cc7c4b9

Update test/test_p4est_2d.jl

163ba43

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Update test/test_p4est_2d.jl

f52285d

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Merge branch 'main' into sc/p4est-view-coupled-enhanced

65126ee

Fixed error of missing 'end' in pest 2d test.

d38742c

Merge branch 'sc/p4est-view-coupled-enhanced' into sc/p4est-view-coup…

5a11404

…led-hanging-nodes

github-actions bot reviewed Nov 20, 2025

View reviewed changes

Added ability to deal with p4est refinment level > 0.

b3b7e3e

github-actions bot reviewed Nov 25, 2025

View reviewed changes

Update src/semidiscretization/semidiscretization_coupled_p4est.jl

cdf9d70

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

-.0,
+.98015167453983, 0.10475978783943254,
+.15551175906375883,
+.0,

+.0,
+.0,
+.0,
+.0,

-.0,
+.026208477271868e-5],
+                            linf=[10.19496728149964, 18.23726813972206,
+.04367783820621,
+.0,

-.03429795097747568,
+.0017266639582675424],
+                            tspan=(0.0, 0.02))
+        # Ensure that we do not have excessive memory allocations
+        # (e.g., from type instabilities)
+        @test_allocations(Trixi.rhs!, semi, sol, 1000)
+    end
+    @trixi_testset "elixir_mhd_rotor_cfl_ramp.jl" begin
+        @test_trixi_include(joinpath(EXAMPLES_DIR, "elixir_mhd_rotor_cfl_ramp.jl"),
+                            l2=[
+.45519051169507474,
+.8917985468745363,
+.8324681609772325,

-.0,
+.9801426190285389,
+.10476233464125001,
+.15551270692826116,
+.0,

-.0,
+.0201603821472296e-5
+                            ],
+                            linf=[
+.196786739705292,
+.267539012179128,
+.046104290498878,
+.0,

-.0,
+.668302849210974,
+.395022093528294,
+.8717844606331189,
+.0,

	@trixi_testset "elixir_advection_basic.jl" begin
	@test_trixi_include(joinpath(EXAMPLES_DIR, "elixir_advection_basic.jl"),
	# Expected errors are exactly the same as with TreeMesh!
	l2=[8.311947673061856e-6],
	linf=[6.627000273229378e-5])
	# Ensure that we do not have excessive memory allocations
	# (e.g., from type instabilities)
	@test_allocations(Trixi.rhs!, semi, sol, 1000)
	semi32 = Trixi.trixi_adapt(Array, Float32, semi)
	@test real(semi32.solver) == Float32
	@test real(semi32.solver.basis) == Float32
	@test real(semi32.solver.mortar) == Float32
	# TODO: remake ignores the mesh itself as well
	@test real(semi32.mesh) == Float64
	end

	@trixi_testset "elixir_advection_restart_amr.jl" begin
	@test_trixi_include(joinpath(EXAMPLES_DIR, "elixir_advection_restart_amr.jl"),
	l2=[2.869137983727866e-6],
	linf=[3.8353423270964804e-5])
	# Ensure that we do not have excessive memory allocations
	# (e.g., from type instabilities)
	@test_allocations(Trixi.rhs!, semi, sol, 1000)
	end

	@trixi_testset "elixir_mhd_alfven_wave.jl" begin
	@test_trixi_include(joinpath(EXAMPLES_DIR, "elixir_mhd_alfven_wave.jl"),
	l2=[1.0513414461545583e-5, 1.0517900957166411e-6,
	1.0517900957304043e-6, 1.511816606372376e-6,
	1.0443997728645063e-6, 7.879639064990798e-7,
	7.879639065049896e-7, 1.0628631669056271e-6,
	4.3382328912336153e-7],
	linf=[4.255466285174592e-5, 1.0029706745823264e-5,
	1.0029706747467781e-5, 1.2122265939010224e-5,
	5.4791097160444835e-6, 5.18922042269665e-6,
	5.189220422141538e-6, 9.552667261422676e-6,
	1.4237578427628152e-6])
	# Ensure that we do not have excessive memory allocations
	# (e.g., from type instabilities)
	let
	t = sol.t[end]
	u_ode = sol.u[end]
	du_ode = similar(u_ode)
	@test (@allocated Trixi.rhs!(du_ode, u_ode, semi, t)) < 1000
	end

	@trixi_testset "elixir_euler_mhd_coupled.jl" begin
	@test_trixi_include(joinpath(EXAMPLES_DIR, "elixir_euler_mhd_coupled.jl"),
	l2=[0.009862595305604965,
	0.011874205535856063,
	5.0185914245237475e-6,
	0.0,
	0.024657539839658474,
	0.0,

	end

	@trixi_testset "elixir_mhd_alfven_wave_nonconforming.jl" begin
	@test_trixi_include(joinpath(EXAMPLES_DIR,
	"elixir_mhd_alfven_wave_nonconforming.jl"),
	l2=[
	0.0322570437144848,
	0.03598284801272945,
	0.03562228071357411,
	0.05288641880143085,
	0.040752873778199326,
	0.04207276835260492,
	0.04171391252403866,
	0.05289242879893149,
	0.0016038935411812223
	],
	linf=[
	0.175984910510666,
	0.13999726708245439,
	0.13336032728399658,
	0.21248359539637798,
	0.133294808938885,
	0.17934684696413217,
	0.1831567822932948,
	0.21575881133569155,
	0.01967917976620703
	],
	tspan=(0.0, 0.25))
	# Ensure that we do not have excessive memory allocations
	# (e.g., from type instabilities)
	@test_allocations(Trixi.rhs!, semi, sol, 1000)
	end

	@trixi_testset "elixir_mhd_rotor.jl" begin
	@test_trixi_include(joinpath(EXAMPLES_DIR, "elixir_mhd_rotor.jl"),
	l2=[0.4551839744017604, 0.8917986079085971, 0.832474072904728,
	0.0,
	0.98015167453983, 0.10475978783943254,
	0.15551175906375883,
	0.0,
	2.026208477271868e-5],
	linf=[10.19496728149964, 18.23726813972206,
	10.04367783820621,
	0.0,
	19.63022306543678, 1.3952679820406384, 1.8716515525771589,
	0.0,
	0.0017266639582675424],
	tspan=(0.0, 0.02))
	# Ensure that we do not have excessive memory allocations
	# (e.g., from type instabilities)
	@test_allocations(Trixi.rhs!, semi, sol, 1000)
	end

	@trixi_testset "elixir_mhd_rotor_cfl_ramp.jl" begin
	@test_trixi_include(joinpath(EXAMPLES_DIR, "elixir_mhd_rotor_cfl_ramp.jl"),
	l2=[
	0.45519051169507474,
	0.8917985468745363,
	0.8324681609772325,
	0.0,
	0.9801426190285389,
	0.10476233464125001,
	0.15551270692826116,
	0.0,
	2.0201603821472296e-5
	],
	linf=[
	10.196786739705292,
	18.267539012179128,
	10.046104290498878,
	0.0,
	19.668302849210974,
	1.395022093528294,
	1.8717844606331189,
	0.0,
	0.001651262488701531
	],
	tspan=(0.0, 0.02))
	# Ensure that we do not have excessive memory allocations
	# (e.g., from type instabilities)
	@test_allocations(Trixi.rhs!, semi, sol, 1000)
	end

	parent_tree_node_coordinates = Array{Real, 2 + 2}(undef, 2, ntuple(_ -> 4, 2)..., n_cells)
	parent_tree_node_coordinates = Array{Real, 2 + 2}(undef, 2, ntuple(_ -> 4, 2)...,
	n_cells)

WIP: Sc/p4est view coupled hanging nodes #2598

Are you sure you want to change the base?

WIP: Sc/p4est view coupled hanging nodes #2598

Uh oh!

Conversation

SimonCan commented Oct 9, 2025

Uh oh!

github-actions bot Nov 20, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Nov 20, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Nov 20, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Nov 20, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Nov 20, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Nov 20, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Nov 20, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Nov 20, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Nov 20, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Nov 20, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Nov 20, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Nov 20, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Nov 20, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants