Adaptive Volume Integral #2601
Draft
Adaptive Volume Integral #2601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ixi.jl into VolumeIntegralAdaptive
DanielDoehring
commented
Oct 13, 2025
DanielDoehring
commented
Oct 14, 2025
ranocha
reviewed
Oct 20, 2025
Comment on lines
+193
to
+194
| Possible combination: [`VolumeIntegralWeakForm`](@ref) and [`VolumeIntegralFluxDifferencing`](@ref). | ||
| TODO: Extend to [`VolumeIntegralWeakForm`](@ref) and [`VolumeIntegralShockCapturingHG`](@ref). |
Member
There was a problem hiding this comment.
There are some TODO notes left. How do you want to handle them?
Member
Author
There was a problem hiding this comment.
This is probably something for the Trixi meeting. The main question is if VolumeIntegralShockCapturingHG should be (internally) re-implemented as a VolumeIntegralAdaptive.
| """ | ||
| VolumeIntegralAdaptive(indicator; | ||
| volume_integral_default = VolumeIntegralWeakForm(), | ||
| volume_integral_stabilized = VolumeIntegralFluxDifferencing(flux_central)) |
Member
There was a problem hiding this comment.
Shall we really prove this as default value? Or should we force people to make a reasonable choice?
| @threaded for element in eachelement(dg, cache) | ||
| stabilized_version = decision[element] | ||
|
|
||
| # TODO: Generalize/Dispatch or introduce yet sub-functions of the volume integrals |
Co-authored-by: Hendrik Ranocha <[email protected]>
Member
|
Please ping me if you would like to have another round of feedback on this PR. |
DanielDoehring
commented
Nov 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having merged #2488 one could realize #2472 and (subsequently) #2149 via this. In fact,
VolumeIntegralShockCapturingHGcould also be brought into this framework.The benefit is greatly reduced computation time of the volume integral, more profound for higher polynomial degrees. For the examples employed in this (draft) PR, the volume integral computation can be roughly reduced by a factor of two.