Skip to content

Conversation

@bennibolm
Copy link
Contributor

This PR also contains the implementation of subcell 3D from bennibolm#143 and 2D idp mortars from #2305.

@bennibolm bennibolm added the enhancement New feature or request label Oct 28, 2025
@github-actions
Copy link
Contributor

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

  • The PR has a single goal that is clear from the PR title and/or description.
  • All code changes represent a single set of modifications that logically belong together.
  • No more than 500 lines of code are changed or there is no obvious way to split the PR into multiple PRs.

Code quality

  • The code can be understood easily.
  • Newly introduced names for variables etc. are self-descriptive and consistent with existing naming conventions.
  • There are no redundancies that can be removed by simple modularization/refactoring.
  • There are no leftover debug statements or commented code sections.
  • The code adheres to our conventions and style guide, and to the Julia guidelines.

Documentation

  • New functions and types are documented with a docstring or top-level comment.
  • Relevant publications are referenced in docstrings (see example for formatting).
  • Inline comments are used to document longer or unusual code sections.
  • Comments describe intent ("why?") and not just functionality ("what?").
  • If the PR introduces a significant change or new feature, it is documented in NEWS.md with its PR number.

Testing

  • The PR passes all tests.
  • New or modified lines of code are covered by tests.
  • New or modified tests run in less then 10 seconds.

Performance

  • There are no type instabilities or memory allocations in performance-critical parts.
  • If the PR intent is to improve performance, before/after time measurements are posted in the PR.

Verification

  • The correctness of the code was verified using appropriate tests.
  • If new equations/methods are added, a convergence test has been run and the results
    are posted in the PR.

Created with ❤️ by the Trixi.jl community.

@codecov
Copy link

codecov bot commented Oct 28, 2025

Codecov Report

❌ Patch coverage is 70.23861% with 686 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.36%. Comparing base (6900d5a) to head (4f49c88).

Files with missing lines Patch % Lines
src/solvers/dgsem_tree/dg_3d_subcell_limiters.jl 41.70% 337 Missing ⚠️
src/solvers/dgsem_p4est/dg_3d_subcell_limiters.jl 57.71% 225 Missing ⚠️
src/equations/ideal_glm_mhd_3d.jl 42.42% 57 Missing ⚠️
src/solvers/dgsem_tree/containers_3d.jl 69.08% 47 Missing ⚠️
src/solvers/dgsem_p4est/subcell_limiters_3d.jl 97.64% 8 Missing ⚠️
src/solvers/dgsem_tree/subcell_limiters_3d.jl 98.27% 6 Missing ⚠️
src/callbacks_stage/subcell_bounds_check_3d.jl 93.65% 4 Missing ⚠️
...llbacks_stage/subcell_limiter_idp_correction_3d.jl 98.02% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##           bb/idp-amr    #2626      +/-   ##
==============================================
- Coverage       96.68%   95.36%   -1.32%     
==============================================
  Files             540      550      +10     
  Lines           44031    46335    +2304     
==============================================
+ Hits            42568    44186    +1618     
- Misses           1463     2149     +686     
Flag Coverage Δ
unittests 95.36% <70.24%> (-1.32%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bennibolm bennibolm force-pushed the bb/idp-amr branch 4 times, most recently from fde10f9 to 6900d5a Compare October 28, 2025 16:03
Adapt maximum allowed allocations

Implement suggestions

Apply changes to 3d code (remove `alpha1/2/3`)

Reset antidiffusive fluxes after resizing in 3d

Add empty line

Fix bug

Nicer line breaks

Move funcs to p4est files

Move even more

Reduce allowed allocs in test

Increase allocs number again

Clean up elixir

Add note to news.md

Update news

Implement suggestions

Update src/callbacks_stage/subcell_limiter_idp_correction_3d.jl

Remove `A4dp1_x/y/z`

Use `maxthreadid()`

Add full 3d implementation on P4estMesh

Add `A5d`

Add 3d TreeMesh implementation

Adapt test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant