Lower-Bound/Positivity-Preserving Limiter of Rueda-Ramirez & Gassner (1D)

[DanielDoehring]

Supersedes #1040

Aims to address #35 (as far as I understand). Will close that issue once the 3D version is merged.

Currently limited to

Trixi.jl/src/time_integration/methods_SSP.jl

Lines 23 to 28 in 413d75f

	struct SimpleSSPRK33{StageCallbacks} <: SimpleAlgorithmSSP
	numerator_a::SVector{3, Float64}
	numerator_b::SVector{3, Float64}
	denominator::SVector{3, Float64}
	c::SVector{3, Float64}
	stage_callbacks::StageCallbacks

due to the easy revert of the DG update:

Trixi.jl/src/time_integration/methods_SSP.jl

Lines 190 to 194 in 413d75f

	# compute du
	integrator.f(integrator.du, integrator.u, integrator.p, t_stage)
	# perform forward Euler step
	@. integrator.u = integrator.u + integrator.dt * integrator.du

this is the place that would need to get adapted if SSP integrators from OrdinaryDiffEq.jl would be used.
Since these methods already dispatch on integrator, extension should be easily possible.

Documentation will follow together with the 2D version

[github-actions]

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

• The PR has a single goal that is clear from the PR title and/or description.
• All code changes represent a single set of modifications that logically belong together.
• No more than 500 lines of code are changed or there is no obvious way to split the PR into multiple PRs.

Code quality

• The code can be understood easily.
• Newly introduced names for variables etc. are self-descriptive and consistent with existing naming conventions.
• There are no redundancies that can be removed by simple modularization/refactoring.
• There are no leftover debug statements or commented code sections.
• The code adheres to our conventions and style guide, and to the Julia guidelines.

Documentation

• New functions and types are documented with a docstring or top-level comment.
• Relevant publications are referenced in docstrings (see example for formatting).
• Inline comments are used to document longer or unusual code sections.
• Comments describe intent ("why?") and not just functionality ("what?").
• If the PR introduces a significant change or new feature, it is documented in NEWS.md with its PR number.

Testing

• The PR passes all tests.
• New or modified lines of code are covered by tests.
• New or modified tests run in less then 10 seconds.

Performance

• There are no type instabilities or memory allocations in performance-critical parts.
• If the PR intent is to improve performance, before/after time measurements are posted in the PR.

Verification

• The correctness of the code was verified using appropriate tests.
• If new equations/methods are added, a convergence test has been run and the results
  are posted in the PR.

Created with ❤️ by the Trixi.jl community.

[ranocha]

What is the status of this PR - waiting for a review (by @amrueda)?

[DanielDoehring]

What is the status of this PR - waiting for a review (by @amrueda)?

Right 👍