-
Notifications
You must be signed in to change notification settings - Fork 135
only one PR for GitHub actions updates #2681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2681 +/- ##
=======================================
Coverage 96.85% 96.85%
=======================================
Files 546 546
Lines 43276 43276
=======================================
Hits 41914 41914
Misses 1362 1362
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
We should probably ignore updates to the downgrade action, see #2507. Currently experimenting with this in NumericalMathematics/DispersiveShallowWater.jl#271. |
andrewwinters5000
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This will make the updates at the beginning of the month much more streamlined.
Good point! I updated the PR accordingly. |
JoshuaLampert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ignoring julia-downgrade-compat doesn't seem to work like this, see NumericalMathematics/DispersiveShallowWater.jl#272. I'll try to figure out why.
Co-authored-by: Joshua Lampert <[email protected]>
JoshuaLampert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
No description provided.