-
Notifications
You must be signed in to change notification settings - Fork 34
fix: publicapi #122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: publicapi #122
Conversation
Summary of ChangesHello @noahpodgurski, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the "Public Api" applet to change its underlying data source and random selection mechanism. Previously, it relied on a dynamic endpoint for random APIs. Now, it fetches a comprehensive list of public APIs from a GitHub repository and performs local random selection, improving control over the data source and reducing the frequency of external API calls by increasing the refresh time. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request refactors the publicapi applet to fetch a list of APIs from a JSON file hosted on GitHub, rather than using the /random endpoint from api.publicapis.org. This is a good change that likely improves reliability. The applet now performs the random selection locally and caches the full list for one week, which is efficient. I've added one comment regarding error handling to make the applet more robust against potential changes in the API response format. Additionally, please note that apps/publicapi/manifest.yaml still contains the old API description in its desc field. It would be good to update it in this PR to maintain consistency.
No description provided.