Skip to content

Conversation

@dustin-decker
Copy link
Contributor

@dustin-decker dustin-decker commented Sep 26, 2025

Description:

This PR introduces a new GitHub Action workflow (.github/workflows/pr-approval-check.yml) that enforces a required approval from a member of the @trufflesecurity/product-eng team for all pull requests.

The workflow creates a product-eng-approval status check, which will be success only if an active @trufflesecurity/product-eng team member has approved the PR. A README.md is also included to explain the workflow and how to configure branch protection to make this check mandatory.

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

Open in Cursor Open in Web

@cursor
Copy link

cursor bot commented Sep 26, 2025

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@CLAassistant
Copy link

CLAassistant commented Sep 26, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ j2fw
❌ cursoragent
You have signed the CLA already but the status is still pending? Let us recheck it.

@j2fw j2fw force-pushed the cursor/require-product-eng-approval-for-prs-f38f branch 2 times, most recently from 040036a to 349d1c7 Compare October 29, 2025 07:49
Copy link
Contributor

@j2fw j2fw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testing pr approval check

@dustin-decker dustin-decker marked this pull request as ready for review October 30, 2025 18:42
@dustin-decker dustin-decker requested a review from a team as a code owner October 30, 2025 18:42
@dustin-decker dustin-decker merged commit 189cd9a into main Oct 30, 2025
15 of 17 checks passed
@dustin-decker dustin-decker deleted the cursor/require-product-eng-approval-for-prs-f38f branch October 30, 2025 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants